Followups for getdeploymentinfo #24187
pull ajtowns wants to merge 5 commits into bitcoin:master from ajtowns:202201-getdepinfo-extra changing 4 files +43 −43-
ajtowns commented at 7:32 am on January 28, 2022: memberDocumentation, comments and trivial code changes to followup #23508.
-
in doc/release-notes-23508.md:11 in 30572275c4 outdated
6+ block, rather than just at the chain tip. Inclusion of soft fork 7+ status in `getblockchaininfo` can currently be restored using the 8+ configuration `-deprecatedrpc=softforks`, but this will be removed in 9+ a future release. Note that in either case, the `status` field 10+ now reflects the status of the current block rather than the next 11+ block. (#23508)
MarcoFalke commented at 7:49 am on January 28, 2022:could move to the main file to avoid having to do it later? (This should be the last snippet for the next release)MarcoFalke commented at 7:50 am on January 28, 2022: memberMaybe also #23508 (review) ?ajtowns added this to the milestone 23.0 on Jan 28, 2022doc: getdeploymentinfo release notes tweaks 555eafa793rpc documentation improvements 32f04e6da9trivial: comment tweaks 5179656ef8rpc/blockchain: a constant craving fbab43f169ajtowns force-pushed on Jan 28, 2022ajtowns commented at 8:14 am on January 28, 2022: memberWas leaving theSoftForkPushBackDesc
argument name change ’til other work that would also touch that, but meh, added.MarcoFalke approvedMarcoFalke commented at 8:21 am on January 28, 2022: memberLGTMMarcoFalke added the label Refactoring on Jan 28, 2022luke-jr commented at 3:36 am on January 31, 2022: memberWe haven’t used the variable style behindpindex
for years now. Why rename to it?Sjors commented at 2:42 pm on January 31, 2022: memberWe haven’t used the variable style behind
pindex
for years now. Why rename to it?We can name it something else (as long as it’s clear we’re not necessarily dealing with the tip).
block_index
or justindex
(I used the latter in thegetblockfrompeer
RPC code)?rpc/blockchain: rename getdeploymentinfo tip/active_chain_tip to blockindex e5f0356e3fajtowns force-pushed on Feb 4, 2022ajtowns commented at 3:50 am on February 4, 2022: memberChanged to blockindex.DrahtBot commented at 5:44 am on February 4, 2022: memberThe following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #24118 (Add ‘sweepwallet’ RPC by Xekyo)
- #21702 (Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
JeremyRubin commented at 6:32 am on February 4, 2022: contributorshrug about renaming tip, easy enough to fix the conflict either way.Sjors commented at 8:58 am on February 4, 2022: memberutACK e5f0356e3ffea10f447998b7549a67e016446e81 @JeremyRubin a rebase beats an off by one soft fork activation error due to unreadable activation-related code :-)MarcoFalke merged this on Feb 14, 2022MarcoFalke closed this on Feb 14, 2022
sidhujag referenced this in commit 2d957724f7 on Feb 14, 2022DrahtBot locked this on Feb 14, 2023
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me