test: Fix sanitizer suppresions in streams_tests #24190

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2201-ts changing 2 files +4 −15
  1. MarcoFalke commented at 9:33 AM on January 28, 2022: member

    Two changes (that also make sense on their own) to remove the file-wide sanitizer suppression:

    • FindByte no longer takes a char, but an uint8_t, after commit 196b4599201dbce3e0317e9b98753fa6a244b82d.
    • The key vector of unsigned chars can be removed and inlined as initializer-list. This avoids a bunch of verbose code like clear() and push_back of chars.
  2. test: Fix sanitizer suppresions in streams_tests faa630aa15
  3. DrahtBot added the label Tests on Jan 28, 2022
  4. DrahtBot commented at 3:56 PM on January 28, 2022: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23962 (Use int32_t type for transaction size/weight consistently by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. PastaPastaPasta approved
  6. PastaPastaPasta commented at 5:21 AM on February 1, 2022: contributor

    utACK faa630aa15bbda0f3b0cf3b6f31cf8fdaeb66975, I have reviewed the changes and agree it makes sense to merge

  7. MarcoFalke merged this on Feb 1, 2022
  8. MarcoFalke closed this on Feb 1, 2022

  9. MarcoFalke deleted the branch on Feb 1, 2022
  10. sidhujag referenced this in commit 2c5bb4a3c2 on Feb 1, 2022
  11. DrahtBot locked this on Feb 1, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me