zmq: Fix implicit-integer-sign-change #24218

1. 
   MarcoFalke commented at 3:54 pm on January 31, 2022: member

   uint256::begin() returns unsigned data, so there is no reason to make it signed.

   Fix that and remove the sanitizer suppression.

2. zmq: Fix implicit-integer-sign-change fa2406a50a
3. MarcoFalke added the label Refactoring on Jan 31, 2022
4. MarcoFalke added the label RPC/REST/ZMQ on Jan 31, 2022
5. hebasto approved
6. 
   hebasto commented at 4:55 pm on January 31, 2022: member

   ACK fa2406a50a83184d101d1bb3f2b282ae280370ba

   uint256::begin() returns unsigned data

   https://github.com/bitcoin/bitcoin/blob/0ff13913287b3874e305535c78bc43b190217168/src/uint256.h#L60

   Although https://github.com/bitcoin/bitcoin/blob/0ff13913287b3874e305535c78bc43b190217168/src/compat/assumptions.h#L37

   why not just unsigned char data[32];?

7. 
   MarcoFalke commented at 5:03 pm on January 31, 2022: member

   why not just unsigned char data[32];?

   • It is more typing
   • It is the same (see assumptions)
8. 
   DrahtBot commented at 8:41 pm on January 31, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23962 (Use int32_t type for transaction size/weight consistently by hebasto)
   • #17786 (refactor: Nuke policy/fees->mempool circular dependencies by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. PastaPastaPasta approved
10. 
    PastaPastaPasta commented at 5:12 am on February 1, 2022: contributor

    utACK fa2406a50a83184d101d1bb3f2b282ae280370ba, I have reviewed the code and think it makes sense
11. MarcoFalke merged this on Feb 1, 2022
12. MarcoFalke closed this on Feb 1, 2022

    ---

13. MarcoFalke deleted the branch on Feb 1, 2022
14. sidhujag referenced this in commit bec0b57409 on Feb 1, 2022
15. Fabcien referenced this in commit 410613b0ae on Dec 9, 2022
16. DrahtBot locked this on Feb 1, 2023

Contributors
MarcoFalke hebasto DrahtBot PastaPastaPasta

Labels
Refactoring RPC/REST/ZMQ