depends: fix capnp's descriptor for make download #24240

pull theuni wants to merge 1 commits into bitcoin:master from theuni:fix-capnp-fetch changing 1 files +1 −0
  1. theuni commented at 5:56 PM on February 2, 2022: member

    The non-native capnp was trying to fetch the wrong file. Without this, "make -C depends MULTIPROCESS=1 download" is broken.

    Presumably it breaks with the download target because the dependency graph is flattened. It manages to work if native_capnp is encountered first because it will then be found in the cache.

  2. depends: fix capnp's descriptor for make download
    The non-native capnp was trying to fetch the wrong file.
    Without this, "make -C depends MULTIPROCESS=1 download" is broken.
    
    Presumably it breaks with the download target because the dependency graph is
    flattened. It manages to work if native_capnp is encountered first because it
    will then be found in the cache.
    01e121d290
  3. laanwj added the label Build system on Feb 2, 2022
  4. hebasto approved
  5. hebasto commented at 6:27 PM on February 2, 2022: member

    ACK 01e121d29087db047e4bc01bd64d054f83cfc5df, tested on Linux Mint 20.2 (x86_64).

    On master:

    $ make -C depends MULTIPROCESS=1 download
    ...
    Fetching capnproto-cxx-0.7.0.tar.gz from https://capnproto.org/
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
    curl: (22) The requested URL returned error: 404
    ...
    

    With this PR:

    $ make -C depends MULTIPROCESS=1 download
    ...
    Fetching capnproto-c++-0.7.0.tar.gz from https://capnproto.org/
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 1443k  100 1443k    0     0   908k      0  0:00:01  0:00:01 --:--:--  908k
    ...
    
  6. laanwj commented at 6:46 PM on February 2, 2022: member

    This is a really strange issue. Concept ACK, of course.

  7. fanquake merged this on Feb 3, 2022
  8. fanquake closed this on Feb 3, 2022

  9. sidhujag referenced this in commit 07a9b2494a on Feb 3, 2022
  10. DrahtBot locked this on Feb 3, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me