p2p: Split network logging into two categories #24247 #24273

pull anshu-khare-design wants to merge 2 commits into bitcoin:master from anshu-khare-design:first_issue changing 9 files +155 −153
  1. anshu-khare-design commented at 5:17 PM on February 5, 2022: none

    This PR is to resolve issue 20576. It focuses on introducing different levels of net logging. As a starting point, as mentioned in the issue #20576 , it creates separate lower-frequency, important peer-level events (netpeers) from very high-frequency message-level passing (netmessages).

  2. p2p: Split network logging into two categories #24247 0dba6126d5
  3. Merge branch 'master' into first_issue 8c20aa0d84
  4. DrahtBot added the label P2P on Feb 5, 2022
  5. DrahtBot commented at 9:28 PM on February 5, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24456 (blockman: Properly guard blockfile members by dongcarl)
    • #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)
    • #24220 (validation: don't re-acquire cs_main during IBD in CChainState::IsInitialBlockDownload() by jonatack)
    • #24178 (p2p: Respond to getheaders if we have sufficient chainwork by sdaftuar)
    • #24008 (assumeutxo: net_processing changes by jamesob)
    • #23443 (p2p: Erlay support signaling by naumenkogs)
    • #22778 (net processing: Reduce resource usage for inbound block-relay-only connections by jnewbery)
    • #22564 (refactor: Move mutable globals cleared in ::UnloadBlockIndex to BlockManager by dongcarl)
    • #21878 (Make all networking code mockable by vasild)
    • #21160 (net/net processing: Move tx inventory into net_processing by jnewbery)
    • #20799 (net processing: Only support version 2 compact blocks by jnewbery)
    • #20726 (p2p: Add DISABLETX message for negotiating block-relay-only connections by sdaftuar)
    • #20196 (net: fix GetListenPort() to derive the proper port by vasild)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. DrahtBot cross-referenced this on Feb 5, 2022 from issue indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky
  7. DrahtBot cross-referenced this on Feb 5, 2022 from issue p2p: Respond to getheaders if we have sufficient chainwork by sdaftuar
  8. DrahtBot cross-referenced this on Feb 6, 2022 from issue assumeutxo: net_processing changes by jamesob
  9. DrahtBot cross-referenced this on Feb 6, 2022 from issue p2p: Erlay support signaling by naumenkogs
  10. DrahtBot cross-referenced this on Feb 6, 2022 from issue net processing: Reduce resource usage for inbound block-relay-only connections by jnewbery
  11. DrahtBot cross-referenced this on Feb 6, 2022 from issue refactor: Release cs_main before MaybeSendFeefilter by MarcoFalke
  12. DrahtBot cross-referenced this on Feb 6, 2022 from issue net/net processing: Move tx inventory into net_processing by jnewbery
  13. DrahtBot cross-referenced this on Feb 6, 2022 from issue net processing: Only support version 2 compact blocks by jnewbery
  14. DrahtBot cross-referenced this on Feb 6, 2022 from issue p2p: Add DISABLETX message for negotiating block-relay-only connections by sdaftuar
  15. DrahtBot cross-referenced this on Feb 6, 2022 from issue assumeutxo by jamesob
  16. fanquake cross-referenced this on Feb 6, 2022 from issue p2p: Split network logging into two categories by anshu-khare-design
  17. DrahtBot cross-referenced this on Feb 8, 2022 from issue validation: don't re-acquire cs_main during IBD in CChainState::IsInitialBlockDownload() by jonatack
  18. DrahtBot cross-referenced this on Feb 14, 2022 from issue Make all networking code mockable by vasild
  19. DrahtBot cross-referenced this on Feb 14, 2022 from issue net: fix GetListenPort() to derive the proper port by vasild
  20. DrahtBot cross-referenced this on Feb 24, 2022 from issue refactor: Move mutable globals cleared in `::UnloadBlockIndex` to `BlockManager` by dongcarl
  21. DrahtBot cross-referenced this on Mar 2, 2022 from issue blockman: Properly guard blockfile members by dongcarl
  22. DrahtBot commented at 2:27 PM on March 3, 2022: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

    <sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>

  23. DrahtBot added the label Needs rebase on Mar 3, 2022
  24. laanwj commented at 6:59 AM on April 14, 2022: member

    Thanks! But instead of splitting up net specifically, I think a better option is to add logging verbosity in general. Closing in favor of #24464.

  25. laanwj closed this on Apr 14, 2022

  26. bitcoin locked this on Apr 14, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 05:53 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me