build, refactor: Drop useless `call` Make function

hebasto commented at 2:05 pm on February 7, 2022: member

Using the call function with $(package)_*_cmds is effectively noop because the latter, which could be found in <package>.mk files, do not use temporary $(1) variable at all.

This PR removes useless calls of the call function, and makes code more readable and easier to reason about.

No change in resulted dependency binaries could be easy verified with bitcoin/bitcoin/#21995.

build, refactor: Drop useless `call` Make function e644591426

hebasto commented at 2:06 pm on February 7, 2022: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 165670faf41fd8f1c705a92bd19254b4021cf12c400ffcac078d45391c18de36a  guix-build-e644591426fb/output/aarch64-linux-gnu/SHA256SUMS.part
 2b81317b5259d93e1f59653d8e7bbe77a041d553e0cae4bb7497b7a2cfe6295ef  guix-build-e644591426fb/output/aarch64-linux-gnu/bitcoin-e644591426fb-aarch64-linux-gnu-debug.tar.gz
 3713a0a152ad55a66435f96a1c007243edecc779d1041acb5e135dfbd2f857f18  guix-build-e644591426fb/output/aarch64-linux-gnu/bitcoin-e644591426fb-aarch64-linux-gnu.tar.gz
 431f5e0d164b61db8da8f396f325091426f5153481a1a86c91bb5713bd4c3531d  guix-build-e644591426fb/output/arm-linux-gnueabihf/SHA256SUMS.part
 5ce36d8574f098ae17d385c615a3c5ea8d64189c669e4457d93e7263be9d9400a  guix-build-e644591426fb/output/arm-linux-gnueabihf/bitcoin-e644591426fb-arm-linux-gnueabihf-debug.tar.gz
 65edfc17ae0771046923a6465805d9ba46c67eb4f7e1e88069c8ea0bb8081fb8a  guix-build-e644591426fb/output/arm-linux-gnueabihf/bitcoin-e644591426fb-arm-linux-gnueabihf.tar.gz
 764b303bd4956d2b4e59d646d9ed64533d503710cfe033793a91d89c95b19cc2d  guix-build-e644591426fb/output/arm64-apple-darwin/SHA256SUMS.part
 8efe60e2bcb113557b2998f0e93d8b87ebf851c67d02c2d830d0c822795240945  guix-build-e644591426fb/output/arm64-apple-darwin/bitcoin-e644591426fb-arm64-apple-darwin.tar.gz
 9b5a1592bbe884777a43f2a4ce6fdde24bfbd71db2984148997f8d92be66e05b8  guix-build-e644591426fb/output/arm64-apple-darwin/bitcoin-e644591426fb-osx-unsigned.dmg
10ae6c5e3b75902cf198a5dd15dc1b9a45a209749a716557b622d75944c6c5094e  guix-build-e644591426fb/output/arm64-apple-darwin/bitcoin-e644591426fb-osx-unsigned.tar.gz
11aee679939caa0bdcebb039f04db0a8df08a486070818051be79b78afcd7978d7  guix-build-e644591426fb/output/dist-archive/bitcoin-e644591426fb.tar.gz
12ea4164e3d8163343cd6f2fa16919513e7c08884c8f19fdd0a4771fa367713595  guix-build-e644591426fb/output/powerpc64-linux-gnu/SHA256SUMS.part
134e952e578b30cfdf6f5679fbeb400556787416e854f35db4756278762bdb2e71  guix-build-e644591426fb/output/powerpc64-linux-gnu/bitcoin-e644591426fb-powerpc64-linux-gnu-debug.tar.gz
14673e523c33aff5d6ba6fa6463755a2710e06525e179425524ece9c972e432b3d  guix-build-e644591426fb/output/powerpc64-linux-gnu/bitcoin-e644591426fb-powerpc64-linux-gnu.tar.gz
15775f51ad557ee13d5254c9376b24fae14cbf49d60ab1e7b852e78a07c30fea1f  guix-build-e644591426fb/output/powerpc64le-linux-gnu/SHA256SUMS.part
165ec61cff14a8e9991fb68f967eb59322617b1b7fe38d31b94e1df06e25cdf516  guix-build-e644591426fb/output/powerpc64le-linux-gnu/bitcoin-e644591426fb-powerpc64le-linux-gnu-debug.tar.gz
176eee56e0f8e462306a4aa7dfb24e9702a5611e8f17097f41dac19aabffb8146d  guix-build-e644591426fb/output/powerpc64le-linux-gnu/bitcoin-e644591426fb-powerpc64le-linux-gnu.tar.gz
1878ec8e65167560de96c44620121a9d633aff8bdfdf82f4eef778c748bcc5c4f9  guix-build-e644591426fb/output/riscv64-linux-gnu/SHA256SUMS.part
1989a5a90e1bd49379c6ba55df6efceb5c78e60d1a92ae76f0038610495b0f052e  guix-build-e644591426fb/output/riscv64-linux-gnu/bitcoin-e644591426fb-riscv64-linux-gnu-debug.tar.gz
20a0a8d5bc849036cfb2411004481bc610e96a35500fc48a7a58575a4a38a1ea7e  guix-build-e644591426fb/output/riscv64-linux-gnu/bitcoin-e644591426fb-riscv64-linux-gnu.tar.gz
215b147457e4d7344587e3d5bcd1d96d2a12a86e6a5ef7e3e9d58bc58f6f72ac0b  guix-build-e644591426fb/output/x86_64-apple-darwin/SHA256SUMS.part
2205fe5b5010e4f01f9b14ec46ca0f44156fd5a5b24109030af443decabb27fc2f  guix-build-e644591426fb/output/x86_64-apple-darwin/bitcoin-e644591426fb-osx-unsigned.dmg
234a4bda289eb8330708e25829b82b4a510cee5c1646048a761ce12757dfc25025  guix-build-e644591426fb/output/x86_64-apple-darwin/bitcoin-e644591426fb-osx-unsigned.tar.gz
241ed06f1b530d4bb7d2288475d8f62f3afa799a7d2408d6e9298abad65fefe11e  guix-build-e644591426fb/output/x86_64-apple-darwin/bitcoin-e644591426fb-osx64.tar.gz
25ee1014d94171f499b2238fa606e9577b18afd40fe928d56ab71db23f7a6c1ec3  guix-build-e644591426fb/output/x86_64-linux-gnu/SHA256SUMS.part
263fba1450bbd26cf676ae3495b32f664296df3cb5c8348b2d9ebce71daab76863  guix-build-e644591426fb/output/x86_64-linux-gnu/bitcoin-e644591426fb-x86_64-linux-gnu-debug.tar.gz
2744150c9849c8b68db2102ca3a92d694279b267d76350660e8ac94929cc2ca144  guix-build-e644591426fb/output/x86_64-linux-gnu/bitcoin-e644591426fb-x86_64-linux-gnu.tar.gz

DrahtBot added the label Build system on Feb 7, 2022

shaavan approved

shaavan commented at 12:45 pm on February 8, 2022: contributor

Code review ACK e644591426fb4ee1bba5c4bfdde85eb378258272

Since in all the instances of call() addressed in this PR, $(1) is equivalent to $(package), and for each package, there is a separate $(package)_*_cmds, where each one had the value of there $(package), hence theoretically there is no need for $(1) value for them. I also cross-checked for all the $(package)_*_cmds functions to see if any of them was using the $(package) as the parameter provided from call(), and I found none. So I think the changes applied in this PR are safe to merge.

DrahtBot commented at 1:28 pm on February 8, 2022: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#24279 (build: Make $(package)_*_env available to all $(package)_*_cmds by hebasto)
#22811 (build: Fix depends build system when working with subtargets by hebasto)
#22126 (build: Disable make builtin rules. by dgoncharov)
#19952 (build, ci: Add file-based logging for individual packages by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj commented at 2:12 pm on February 9, 2022: member

Code review ACK e644591426fb4ee1bba5c4bfdde85eb378258272 Might want to ping @theuni on whether he had a specific reason to use call here.

laanwj merged this on Apr 13, 2022

laanwj closed this on Apr 13, 2022

hebasto deleted the branch on Apr 13, 2022

sidhujag referenced this in commit 3aae98de32 on Apr 14, 2022

fanquake referenced this in commit ab5b26f072 on Feb 7, 2023

sidhujag referenced this in commit 3334b67f09 on Feb 7, 2023

DrahtBot locked this on Apr 13, 2023

build, refactor: Drop useless call Make function #24285

Guix builds:

Conflicts

build, refactor: Drop useless `call` Make function #24285