Fix unintended unsigned integer overflow in strencodings #24297

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2202-unInt changing 1 files +1 −1
  1. MarcoFalke commented at 12:28 PM on February 9, 2022: member

    This fixes two issues for strings that start with a colon and only have one colon:

    • fMultiColon is incorrectly set to true
    • There is an unsigned integer overflow colon - 1 (0 - 1)

    Neither issue matters, as the result is discarded. Though, it makes sense to still fix the issue for clarity and to avoid sanitizer issues in the function.

  2. Fix unintended unsigned integer overflow in strencodings fac9fe5d05
  3. MarcoFalke added the label Refactoring on Feb 9, 2022
  4. laanwj commented at 1:52 PM on February 9, 2022: member

    Code review ACK fac9fe5d051264fcd16e8e36d30f28c05c999837

  5. shaavan approved
  6. shaavan commented at 3:07 PM on February 9, 2022: contributor

    Code Review ACK fac9fe5d051264fcd16e8e36d30f28c05c999837

    Though the result of this section is discarded, I think it makes to keep the code correct as it keeps the code logically sound, while also avoid risk of potential future bugs, due to this piece of code.

  7. fanquake merged this on Feb 10, 2022
  8. fanquake closed this on Feb 10, 2022

  9. MarcoFalke deleted the branch on Feb 10, 2022
  10. sidhujag referenced this in commit 7b3d3acb9f on Feb 10, 2022
  11. DrahtBot locked this on Feb 10, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me