Move GenerateBitcoins() call out of net.cpp's StartNode() #2431

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:gen-bitcoins-init changing 2 files +3 −3

jgarzik commented at 5:58 AM on March 31, 2013: contributor

The internal miner is closely bound to the wallet engine, not the blockchain engine.

This small cleanup was cherry-picked from #2154 because it is useful beyond the obvious merits: it gets closer to my goal of fork()'ing away the blockchain engine.

Note that this commit places GenerateBitcoins() after RPC server start, unlike #2154 which employs a stub thread.

Move GenerateBitcoins() call out of net.cpp's StartNode()

The internal miner is closely bound to the wallet engine,
not the blockchain engine.

a0cafb7945

sipa commented at 6:46 AM on March 31, 2013: member

ACK if this doesn't conflict with Gavin's thread cleanup.
laanwj commented at 2:44 PM on April 1, 2013: member

ACK
Diapolo commented at 8:22 AM on April 2, 2013: none

ACK
jgarzik commented at 2:42 PM on April 2, 2013: contributor

Ping @gavinandresen
gavinandresen referenced this in commit 06db61f09e on Apr 2, 2013
gavinandresen merged this on Apr 2, 2013
gavinandresen closed this on Apr 2, 2013
laudney referenced this in commit b7a77cf315 on Mar 19, 2014
jgarzik deleted the branch on Aug 24, 2014
DrahtBot locked this on Sep 8, 2021

Contributors