refactor: Avoid unsigned integer overflow in core_write #24319

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2202-intW changing 2 files +1 −2
  1. MarcoFalke commented at 4:23 PM on February 11, 2022: member

    Also, I find the new code a bit easier to understand.

  2. refactor: Avoid unsigned integer overflow in core_write fa6065661a
  3. MarcoFalke added the label Refactoring on Feb 11, 2022
  4. fanquake requested review from laanwj on Feb 12, 2022
  5. shaavan approved
  6. shaavan commented at 11:18 AM on February 12, 2022: contributor

    Code Review ACK fa6065661a86656a29e89ed1a3529cb7103f5394

    This change prevents providing integral -1 as the value of length argument for substr function, preventing unsigned integer overflow warning.

  7. luke-jr approved
  8. luke-jr commented at 1:38 AM on February 13, 2022: member

    utACK

  9. MarcoFalke merged this on Feb 14, 2022
  10. MarcoFalke closed this on Feb 14, 2022

  11. MarcoFalke deleted the branch on Feb 14, 2022
  12. sidhujag referenced this in commit 98383206b2 on Feb 14, 2022
  13. DrahtBot locked this on Feb 14, 2023


laanwj


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me