Also, I find the new code a bit easier to understand.
refactor: Avoid unsigned integer overflow in core_write #24319
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2202-intW changing 2 files +1 −2-
MarcoFalke commented at 4:23 PM on February 11, 2022: member
-
refactor: Avoid unsigned integer overflow in core_write fa6065661a
- MarcoFalke added the label Refactoring on Feb 11, 2022
- fanquake requested review from laanwj on Feb 12, 2022
- shaavan approved
-
shaavan commented at 11:18 AM on February 12, 2022: contributor
Code Review ACK fa6065661a86656a29e89ed1a3529cb7103f5394
This change prevents providing integral -1 as the value of length argument for
substrfunction, preventing unsigned integer overflow warning. - luke-jr approved
-
luke-jr commented at 1:38 AM on February 13, 2022: member
utACK
- MarcoFalke merged this on Feb 14, 2022
- MarcoFalke closed this on Feb 14, 2022
- MarcoFalke deleted the branch on Feb 14, 2022
- sidhujag referenced this in commit 98383206b2 on Feb 14, 2022
- DrahtBot locked this on Feb 14, 2023