A disabled enable_fuzz on current master does not mean the the fuzz binary is not compiled. This is confusion, so fix it.
enable_fuzz toggles compilation flags for fuzzing and disables all other target. There is no need to print this in the configure result, because the compilation flags are already printed. Also, all other targets are already printed as no.enable_fuzz_binary does what it says it does and is currently not printed. So print it.1950 | @@ -1951,8 +1951,8 @@ if test $enable_fuzz = "no"; then 1951 | echo " with test = $use_tests" 1952 | else 1953 | echo " with test = not building test_bitcoin because fuzzing is enabled" 1954 | - echo " with fuzz = $enable_fuzz" 1955 | fi 1956 | +echo " with fuzz = $enable_fuzz_binary"
Just "with fuzz = yes" is still confusing to me. For someone it could be unclear that this message is related to the --enable-fuzz-binary flag. Maybe add "binary" word?
thx, fixed
Concept ACK.
ACK faef344f84a566436ffe2a277dec2cd6c7e1664b, tested on Linux Mint 20.2 (x86_64):
$ ./configure 2>&1 | grep -i fuzz
with fuzz binary = yes
CPPFLAGS = -fmacro-prefix-map=$(abs_top_srcdir)=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -DPROVIDE_FUZZ_MAIN_FUNCTION
$ ./configure --disable-fuzz-binary 2>&1 | grep -i fuzz
configure: running /bin/bash ./configure --disable-option-checking '--prefix=/usr/local' '--disable-fuzz-binary' '--disable-shared' '--with-pic' '--enable-benchmark=no' '--enable-module-recovery' '--enable-module-schnorrsig' '--enable-experimental' --cache-file=/dev/null --srcdir=.
with fuzz binary = no
CPPFLAGS = -fmacro-prefix-map=$(abs_top_srcdir)=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -DPROVIDE_FUZZ_MAIN_FUNCTION
Btw, it looks like the setting of the -DPROVIDE_FUZZ_MAIN_FUNCTION flag should be revisited.
Btw, it looks like the setting of the -DPROVIDE_FUZZ_MAIN_FUNCTION flag should be revisited.
Why? A binary needs a main function, otherwise it can't be linked. Maybe create a separate issue if there is one?