doc: Fix typos #24359

pull acktsap wants to merge 1 commits into bitcoin:master from acktsap:fix-the-the-comment changing 3 files +3 −3

acktsap commented at 5:54 PM on February 16, 2022: contributor

Fix typos.

in src/wallet/test/wallet_tests.cpp:429 in b5a36f053b outdated

 425 | @@ -426,7 +426,7 @@ BOOST_AUTO_TEST_CASE(LoadReceiveRequests)
 426 |  
 427 |  // Test some watch-only LegacyScriptPubKeyMan methods by the procedure of loading (LoadWatchOnly),
 428 |  // checking (HaveWatchOnly), getting (GetWatchPubKey) and removing (RemoveWatchOnly) a
 429 | -// given PubKey, resp. its corresponding P2PK Script. Results of the the impact on
 430 | +// given PubKey, resp. its corresponding P2PK Script. Results of the impact on

jonatack commented at 5:59 PM on February 16, 2022:

I guess someone really likes the band? anyway, ACK but could you also fix this one while here

$ test/lint/lint-spelling.sh 
src/crypto/sha256_arm_shani.cpp:65: implemenation ==> implementation

Edit: would probably make more sense to prefix the PR with doc: instead of node, wallet:

acktsap commented at 6:35 PM on February 16, 2022:

Done! https://github.com/bitcoin/bitcoin/pull/24359/commits/9c2bb5a2b499663c386aa9641baa85558aaa25ff

acktsap renamed this:
~~node, wallet: Fix 'the the' in comments~~
doc: Fix 'the the' in comments
on Feb 16, 2022
acktsap renamed this:
~~doc: Fix 'the the' in comments~~
doc: Fix typos
on Feb 16, 2022
jonatack commented at 6:36 PM on February 16, 2022: member

Can you please squash the commits down to one prefixed by "doc:" (or no prefix).
doc: Fix typos ba4906f951
acktsap force-pushed on Feb 16, 2022
acktsap commented at 6:46 PM on February 16, 2022: contributor

Squash & force pushed in https://github.com/bitcoin/bitcoin/commit/ba4906f951d9f436d9669701fdb3b6e2884121f3
DrahtBot added the label Block storage on Feb 16, 2022
DrahtBot added the label Utils/log/libs on Feb 16, 2022
DrahtBot added the label Wallet on Feb 16, 2022
unknown approved
unknown commented at 9:22 PM on February 16, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/24359/commits/ba4906f951d9f436d9669701fdb3b6e2884121f3
Zero-1729 commented at 9:29 PM on February 16, 2022: contributor

crACK ba4906f951d9f436d9669701fdb3b6e2884121f3
jonatack approved
jonatack commented at 9:37 PM on February 16, 2022: member

This is the day your life will surely change https://www.youtube.com/watch?v=7ZYgKCbFbWY

ACK ba4906f951d9f436d9669701fdb3b6e2884121f3
MarcoFalke removed the label Wallet on Feb 17, 2022
MarcoFalke removed the label Block storage on Feb 17, 2022
MarcoFalke removed the label Utils/log/libs on Feb 17, 2022
MarcoFalke added the label Docs on Feb 17, 2022
MarcoFalke merged this on Feb 17, 2022
MarcoFalke closed this on Feb 17, 2022
DrahtBot locked this on Feb 17, 2023

Contributors

Labels