doc: improve -netinfo help based on feedback from users and devs #24360

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:netinfo-doc-improvements changing 1 files +7 −6

jonatack commented at 5:55 PM on February 16, 2022: member

Clarify which networks are displayed by the peer counts table (reachable networks; follow-up to #23324) in response to questions received over the past months, and a few other improvements.

Improve -netinfo help based on feedback from users and devs

- clarify that the peer counts table is of reachable networks

- a few other clarifications

a4da16fbd4

DrahtBot added the label Utils/log/libs on Feb 16, 2022
brunoerg commented at 7:25 PM on February 16, 2022: member

Concept ACK
w0xlt approved
w0xlt commented at 8:13 PM on February 16, 2022: contributor

ACK a4da16f

in src/bitcoin-cli.cpp:614 in a4da16fbd4

 611 | +        "                                  0 - Peer counts for each reachable network as well as for block relay peers\n"
 612 | +        "                                      and manual peers, and the list of local addresses and ports\n"
 613 | +        "                                  1 - Like 0 but preceded by a peers listing (without address and version columns)\n"
 614 |          "                                  2 - Like 1 but with an address column\n"
 615 |          "                                  3 - Like 1 but with a version column\n"
 616 |          "                                  4 - Like 1 but with both address and version columns\n"

laanwj commented at 11:40 AM on February 17, 2022:

Heh we kind of went out of hand with the number of combinations here.

laanwj commented at 11:40 AM on February 17, 2022: member

Code review ACK a4da16fbd43ea1fff344f1602f7a5ace3d4a8a95
kristapsk approved
kristapsk commented at 6:16 AM on February 18, 2022: contributor

utACK a4da16fbd43ea1fff344f1602f7a5ace3d4a8a95
MarcoFalke merged this on Feb 18, 2022
MarcoFalke closed this on Feb 18, 2022
jonatack deleted the branch on Feb 18, 2022
sidhujag referenced this in commit 5a912a4306 on Feb 19, 2022
DrahtBot locked this on Feb 18, 2023

Contributors

Labels

Linked (view graph)

#23324 Print peer counts for all reachable networks in -netinfo