User-facing content and codebase doc fixups from transifex translator feedback #24367

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:fixes-based-on-transifex-translator-feedback changing 18 files +23 −23
  1. jonatack commented at 12:45 pm on February 17, 2022: member
    Closes #24366.
  2. User-facing content fixups from transifex translator feedback e670edd434
  3. jonatack commented at 12:47 pm on February 17, 2022: member
    (When to use cannot vs can not: https://writingexplained.org/cannot-or-can-not-difference. The cases when “can not” would be used are somewhat rare and not encountered here.)
  4. jonatack renamed this:
    User-facing content fixups from transifex translator feedback
    User-facing content and codebase doc fixups from transifex translator feedback
    on Feb 17, 2022
  5. ghost commented at 12:57 pm on February 17, 2022: none

    (When to use cannot vs can not: https://writingexplained.org/cannot-or-can-not-difference. The cases when “can not” would be used are somewhat rare and not encountered here.)

    Based on this link: https://english.stackexchange.com/questions/4510/why-is-cannot-spelled-as-one-word both look okay to me.

    Overall I have no issues with the changes made in this PR.

    ACK https://github.com/bitcoin/bitcoin/pull/24367/commits/4982b329b7d4f0e0343b0fa23b19d1a538eca4d6

  6. in doc/build-unix.md:257 in 4982b329b7 outdated 
    253@@ -254,7 +254,7 @@ Hardening enables the following features:
254     randomly located as well.
255 
256     On an AMD64 processor where a library was not compiled with -fPIC, this will cause an error
257-    such as: "relocation R_X86_64_32 against `......' can not be used when making a shared object;"
258+    such as: "relocation R_X86_64_32 against `......' cannot be used when making a shared object;"
    hebasto commented at 1:08 pm on February 17, 2022:
    This string looks being copy-pasted from other source. Should we alter it?
    jonatack commented at 1:12 pm on February 17, 2022:
    Not sure, I thought about this, but the “such as:” preceding it seems to suggest only an example (and one that could be updated over time), so this change might avoid someone proposing to “fix” it.
    laanwj commented at 2:39 pm on February 21, 2022:
    Yes, it looks to me it is a compiler message. Better for search ability to leave it as is.
    jonatack commented at 6:09 pm on February 21, 2022:
    Thanks, done.
  7. hebasto commented at 1:08 pm on February 17, 2022: member
    Concept ACK.
  8. hebasto approved
  9. hebasto commented at 1:13 pm on February 17, 2022: member
    ACK 4982b329b7d4f0e0343b0fa23b19d1a538eca4d6
  10. jonatack commented at 1:16 pm on February 17, 2022: member
    (TBH I’d noticed most of this diff before but thought they were too pedantic to propose changing. To my mind this is more to avoid spending further time on it.)
  11. hebasto commented at 1:18 pm on February 17, 2022: member

    (TBH I’d noticed most of this diff before but thought they were too pedantic to propose changing. To my mind this is more to avoid spending further time on it.)

    Translators forms a good focus-group for Bitcoin Core UI testing :)

  12. DrahtBot added the label GUI on Feb 17, 2022
  13. DrahtBot added the label P2P on Feb 17, 2022
  14. DrahtBot added the label RPC/REST/ZMQ on Feb 17, 2022
  15. DrahtBot added the label Scripts and tools on Feb 17, 2022
  16. DrahtBot added the label UTXO Db and Indexes on Feb 17, 2022
  17. DrahtBot added the label Validation on Feb 17, 2022
  18. DrahtBot added the label Wallet on Feb 17, 2022
  19. w0xlt approved
  20. w0xlt commented at 1:45 pm on February 18, 2022: contributor
    ACK 4982b32
  21. in src/wallet/spend.cpp:781 in 4982b329b7 outdated 
    777@@ -778,7 +778,7 @@ static bool CreateTransactionInternal(
778     }
779     else if ((unsigned int)nChangePosInOut > txNew.vout.size())
780     {
781-        error = _("Change index out of range");
    luke-jr commented at 0:24 am on February 19, 2022:
    ACK
  22. luke-jr commented at 0:26 am on February 19, 2022: member
    I think the current strings are better, and don’t see rationale for changing them (exception ACK’d)
  23. jonatack commented at 5:10 pm on February 20, 2022: member

    I think the current strings are better, and don’t see rationale for changing them (exception ACK’d)

    That leaves

    • “free space available”, which I agree may not bother native speakers (it doesn’t bother me, at least) but I can see why it may appear redundant to non-natives / English-as-a-second language speakers (as seen in the referenced issue in the PR description), so we may as well avoid the issue coming up
    • “can not”, for which there are explanations and links above
  24. jonatack commented at 1:40 pm on February 21, 2022: member
    Summary: this has 3 ACKs from @prayank23, @hebasto and @w0xlt
  25. laanwj removed the label Wallet on Feb 21, 2022
  26. laanwj removed the label UTXO Db and Indexes on Feb 21, 2022
  27. laanwj removed the label RPC/REST/ZMQ on Feb 21, 2022
  28. laanwj removed the label P2P on Feb 21, 2022
  29. laanwj removed the label Validation on Feb 21, 2022
  30. laanwj removed the label Scripts and tools on Feb 21, 2022
  31. laanwj commented at 2:46 pm on February 21, 2022: member
    Code review ACK https://github.com/bitcoin/bitcoin/pull/24367/commits/4982b329b7d4f0e0343b0fa23b19d1a538eca4d6 Code review re-ACK 48742693acc9de837735674057c9aae2fe90bd1d But would prefer the change in build-unix.md to be reverted, it’s better to quote error messages verbatim even if they contain typos. (addressed)
  32. Replace "can not" with "cannot" in docs, user messages, and tests 48742693ac
  33. jonatack force-pushed on Feb 21, 2022
  34. jonatack commented at 6:12 pm on February 21, 2022: member
    Updated per review feedback to leave the error example as-is in doc/build-unix.md. Thanks!
  35. hebasto approved
  36. hebasto commented at 6:13 pm on February 21, 2022: member
    re-ACK 48742693acc9de837735674057c9aae2fe90bd1d, only suggested change since my previous review.
  37. laanwj merged this on Feb 22, 2022
  38. laanwj closed this on Feb 22, 2022
  39. in src/wallet/spend.cpp:781 in 48742693ac 
    777@@ -778,7 +778,7 @@ static bool CreateTransactionInternal(
778     }
779     else if ((unsigned int)nChangePosInOut > txNew.vout.size())
780     {
781-        error = _("Change index out of range");
782+        error = _("Transaction change output index out of range");
    MarcoFalke commented at 12:12 pm on February 22, 2022:
    Is there any value in translating this? I mean it is not possible to set the change position via the GUI, no?
  40. jonatack deleted the branch on Feb 22, 2022
  41. sidhujag referenced this in commit 88bd0e3886 on Feb 22, 2022
  42. DrahtBot locked this on Feb 22, 2023


jonatack ghost hebasto laanwj w0xlt luke-jr MarcoFalke

Labels
GUI

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me