wallet: Add external-signer-support specific error message #24401

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:220220-signer changing 3 files +6 −1

hebasto commented at 7:10 PM on February 20, 2022: member

On master (5f44c5c428b696af4214b2519cb2bbeb0e4a1027) an attempt to load an external signer wallet using Bitcoin Core compiled without external signer support fails with the following log messages:

2022-02-20T19:01:11Z [qt-walletctrl] Using SQLite Version 3.31.1
2022-02-20T19:01:11Z [qt-walletctrl] Using wallet /home/hebasto/.bitcoin/testnet3/wallets/coldcard-0220
2022-02-20T19:01:11Z [qt-walletctrl] init message: Loading wallet…
2022-02-20T19:01:11Z [qt-walletctrl] [coldcard-0220] Error: External signer wallet being loaded without external signer support compiled
2022-02-20T19:01:11Z [qt-walletctrl] [coldcard-0220] Releasing wallet

While log messages are good, a message in the GUI window is completely misleading:

Screenshot from 2022-02-20 20-43-46

This PR fixes this issue:

Screenshot from 2022-02-20 21-01-18

wallet: Add external-signer-support specific error message 7f3a6a9495
DrahtBot added the label Wallet on Feb 20, 2022
kristapsk approved
kristapsk commented at 9:02 PM on February 20, 2022: contributor

ACK 7f3a6a9495fafbf77f221297615fa56dc3ecc64a
kristapsk commented at 9:04 PM on February 20, 2022: contributor

Not related to this PR, but what I noticed - it seems there is no normal way of unloading wallet in this case, bitcoind / bitcoin-qt will refuse to start. Only workaround is to manually edit settings.json and remove it from there.
brunoerg approved
brunoerg commented at 12:28 AM on February 22, 2022: member

crACK 7f3a6a9495fafbf77f221297615fa56dc3ecc64a
achow101 commented at 10:18 PM on February 23, 2022: member

ACK 7f3a6a9495fafbf77f221297615fa56dc3ecc64a
achow101 merged this on Feb 23, 2022
achow101 closed this on Feb 23, 2022
hebasto deleted the branch on Feb 24, 2022
laanwj referenced this in commit 38020c4f2e on Feb 24, 2022
fanquake referenced this in commit c07287d34c on Feb 24, 2022
sidhujag referenced this in commit adebc05bc5 on Feb 24, 2022
luke-jr commented at 9:42 PM on March 5, 2022: member

Not related to this PR, but what I noticed - it seems there is no normal way of unloading wallet in this case, bitcoind / bitcoin-qt will refuse to start. Only workaround is to manually edit settings.json and remove it from there.

See https://github.com/bitcoin-core/gui/pull/236
janus referenced this in commit 688d1922e1 on Jul 24, 2022
backpacker69 referenced this in commit 8ab413311e on Jan 18, 2023
DrahtBot locked this on Mar 5, 2023

Contributors

Labels