build: Fix Boost.Process test for Boost 1.78 #24415

1. 
   hebasto commented at 10:22 am on February 22, 2022: member

   Fixes bitcoin/bitcoin#24413.

   An alternative to bitcoin/bitcoin#24414.

2. build: Fix Boost.Process test for Boost 1.78 d092dfb1b3
3. 
   Sjors commented at 10:41 am on February 22, 2022: member

   tACK d092dfb1b3f1fadbb22ff5605176979a78b623a2
4. DrahtBot added the label Build system on Feb 22, 2022
5. 
   Sjors commented at 12:16 pm on February 22, 2022: member

   The MSVC failure seems unrelated (see #24151):

   0 test  2022-02-22T11:44:36.374000Z TestFramework (ERROR): Assertion failed 
   1                                   Traceback (most recent call last):
   2                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 132, in main
   3                                       self.run_test()
   4                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\wallet_send.py", line 560, in run_test
   5                                       assert_fee_amount(testres["fees"]["base"], testres["vsize"], Decimal(0.0001))
   6                                     File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\util.py", line 46, in assert_fee_amount
   7                                       raise AssertionError("Fee of %s BTC too high! (Should be %s BTC)" % (str(fee), str(target_fee)))
   8                                   AssertionError: Fee of 0.00003160 BTC too high! (Should be 0.0000313 BTC)
   

6. 
   DrahtBot commented at 4:30 pm on February 22, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24397 (build: Fix Boost.Process check for Boost 1.73 and older by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. DrahtBot added the label Needs rebase on Feb 28, 2022
8. 
   DrahtBot commented at 3:05 pm on February 28, 2022: member

   🐙 This pull request conflicts with the target branch and needs rebase.

   Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

9. in configure.ac:1444 in d092dfb1b3

   1437@@ -1438,9 +1438,14 @@ if test "$use_external_signer" != "no"; then
   1438     ;;
   1439     *)
   1440       AC_MSG_CHECKING([whether Boost.Process can be used])
   1441+      TEMP_CXXFLAGS="$CXXFLAGS"
   1442+      dnl Boost 1.78 requires the following workaround.
   1443+      dnl See: https://github.com/boostorg/process/issues/235
   1444+      CXXFLAGS="$CXXFLAGS -Wno-narrowing"
   

   ---

   ---

   

   luke-jr commented at 9:59 pm on March 7, 2022:

   0      CXXFLAGS="$CXXFLAGS -Wno-error=narrowing"
   

10. luke-jr changes_requested
11. 
    luke-jr commented at 10:00 pm on March 7, 2022: member

    Seems like -Werror should simply always use --enable-suppress-external-warnings

    And never enable -Werror for configure checks…

12. 
    hebasto commented at 12:06 pm on March 10, 2022: member

    Not able to continue to work on this PR (no access to macOS x86_64), and will be happy if someone grab it.
13. hebasto closed this on Mar 10, 2022

    ---

14. hebasto added the label Up for grabs on Mar 10, 2022
15. 
    MarcoFalke commented at 12:13 pm on March 10, 2022: member

    Looks like this had a tested ACK, so if we want it, it can be merged as-is, unless there are concerns with it.
16. 
    hebasto commented at 12:16 pm on March 10, 2022: member

    Looks like this had a tested ACK, so if we want it, it can be merged as-is, unless there are concerns with it.

    It requires rebasing, and @luke-jr’s suggestion deserves testing.

17. 
    MarcoFalke commented at 12:18 pm on March 10, 2022: member

    Ah sorry, I missed the rebase label.
18. fanquake removed the label Up for grabs on Mar 10, 2022
19. laanwj referenced this in commit 9e32adbb5c on Mar 29, 2022
20. sidhujag referenced this in commit dd7ed96fc1 on Apr 3, 2022
21. hebasto deleted the branch on Apr 4, 2022
22. DrahtBot locked this on Apr 4, 2023

Contributors
hebasto Sjors DrahtBot luke-jr MarcoFalke

Labels
Build system Needs rebase