Chainparams update for 23.x #24418

pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2022-02-chainparams-update changing 1 files +19 −19
  1. laanwj commented at 3:43 pm on February 22, 2022: member

    Update chain parameters for upcoming major release. See doc/release-process.md for review instructions.

    • m_assumed_blockchain_size, m_assumed_chain_state_size:
     0bitcoin$ du -h .
 1105M    ./blocks/index
 2415G    ./blocks
 34.5G    ./chainstate
 4420G    .
 5bitcoin$ python3
 6Python 3.9.10 (main, Jan 16 2022, 17:12:18)
 7[GCC 11.2.0] on linux
 8Type "help", "copyright", "credits" or "license" for more information.
 9>>> 420 * 1.1
10462.00000000000006
11>>> 5 * 1.1
125.5
    • chainTxData:
     0cli getchaintxstats 4096 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
 1{
 2  "time": 1645542140,
 3  "txcount": 712531200,
 4  "window_final_block_hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
 5  "window_final_block_height": 724466,
 6  "window_block_count": 4096,
 7  "window_tx_count": 6950257,
 8  "window_interval": 2404071,
 9  "txrate": 2.891036496010309
10}
    • nMinimumChainWork, defaultAssumeValid:
     0$ cli getblockhash 724466 # was two from the tip at the time
 1000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
 2$ cli getblockheader 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
 3{
 4  "hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
 5  "confirmations": 3,
 6  "height": 724466,
 7  "version": 939515908,
 8  "versionHex": "37ffe004",
 9  "merkleroot": "35a08d9647972e7c3ec39ee7f4ab434f03445de7c446a4d1acc1254b4546bbbe",
10  "time": 1645542140,
11  "mediantime": 1645539567,
12  "nonce": 188699556,
13  "bits": "170a1078",
14  "difficulty": 27967152532434.23,
15  "chainwork": "00000000000000000000000000000000000000002927cdceccbd5209e81e80db",
16  "nTx": 1948,
17  "previousblockhash": "000000000000000000075e26c23c2ecec4e34699411ccd712ff6f2d252f65a78",
18  "nextblockhash": "0000000000000000000905369cd69f68323e3e8da2933a78bea0b2cdb8baa89f"
19}
  2. laanwj added the label Utils/log/libs on Feb 22, 2022
  3. laanwj added this to the milestone 23.0 on Feb 22, 2022
  4. DrahtBot commented at 4:05 pm on February 22, 2022: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21702 (Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. in src/chainparams.cpp:172 in 7d4d5ef0c5 outdated 
    171-            /* nTxCount */ 656509474,
172-            /* dTxRate  */ 2.424920418708139,
173+            // Data from RPC: getchaintxstats 4320 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
174+            /* nTime    */ 1645542140,
175+            /* nTxCount */ 712531200,
176+            /* dTxRate  */ 2.911573625926285,
    jonatack commented at 10:50 pm on February 22, 2022:

    d8a8b54 update ChainTxData for testnet and signet too? (they were last updated in eeddd1c8fa9)

    same for nMinimumChainWork and defaultAssumeValid

    jonatack commented at 10:52 pm on February 22, 2022:
    (side note, I have 41.4 GiB of /indexes on mainnet (4 GiB on testnet), wonder if that space ought to be taken into account somewhere)
    laanwj commented at 12:47 pm on February 23, 2022:

    Could do it seperately. I don’t have any testnet node at the moment, mainnet is definitely the one requiring the more thorough review/testing. Edit: all three networks are now covered

    (side note, I have 41.4 GiB of /indexes on mainnet (4 GiB on testnet), wonder if that space ought to be taken into account somewhere)

    Good point, but I’m simply following the release process here. It could be updated to include indexes, but I don’t have any indexes myself, I guess we assume a default setup without them? That makes some sense for new users (remember, this is for the GUI).

  6. in src/chainparams.cpp:169 in 7d4d5ef0c5 outdated 
    165@@ -166,10 +166,10 @@ class CMainParams : public CChainParams {
166         };
167 
168         chainTxData = ChainTxData{
169-            // Data from RPC: getchaintxstats 4096 00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad
170-            /* nTime    */ 1626697539,
171-            /* nTxCount */ 656509474,
172-            /* dTxRate  */ 2.424920418708139,
173+            // Data from RPC: getchaintxstats 4320 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
    laanwj commented at 3:04 pm on February 23, 2022:

    Does this need to be 4096 blocks? The reason I changed this to 4320 is that it’s what getchaintxstats returns by default, but it seems we’ve always explicitly used 4096.

    Edit: updated to 4096 just to be sure.

    jonatack commented at 3:33 pm on February 24, 2022:
    I wonder why 28 days (4096) was used instead of the getchaintxstats default of 30 (4320).
  7. laanwj force-pushed on Feb 23, 2022
  8. laanwj commented at 3:18 pm on February 23, 2022: member
    Changed to getchaintxstats 4096 (instead of 4320) because that’s what we’ve always done.
  9. sdaftuar commented at 3:18 pm on February 23, 2022: member

    My testnet data (I just used the current tip – should I go back a few weeks?)

    0# du -h testnet3
1335M	testnet3/blocks/index
229G	testnet3/blocks
31.4G	testnet3/chainstate
459G	testnet3

     0# # bin/bitcoin-cli -testnet getchaintxstats 4096 00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e
 1{
 2  "time": 1645635119,
 3  "txcount": 62226341,
 4  "window_final_block_hash": "00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e",
 5  "window_final_block_height": 2163398,
 6  "window_block_count": 4096,
 7  "window_tx_count": 44718,
 8  "window_interval": 579399,
 9  "txrate": 0.07717997442177152
10}

     0# bin/bitcoin-cli -testnet getblockhash 2163398
 100000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e
 2
 3# bin/bitcoin-cli -testnet getblockheader 00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e
 4{
 5  "hash": "00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e",
 6  "confirmations": 1,
 7  "height": 2163398,
 8  "version": 536870912,
 9  "versionHex": "20000000",
10  "merkleroot": "098571ff08c01435151059a176aa8cecb3c374f7803322b7a4e61202aaf225fd",
11  "time": 1645635119,
12  "mediantime": 1645632662,
13  "nonce": 2157408116,
14  "bits": "1d00ffff",
15  "difficulty": 1,
16  "chainwork": "0000000000000000000000000000000000000000000006480a8f8cd1a50d40b4",
17  "nTx": 2,
18  "previousblockhash": "0000000077b52bb2803f93dfc079c23904f5c5f0a68d693d44f5a4195e135670"
19}

    Edit: going back 20000 blocks:

     0# bin/bitcoin-cli -testnet getblockhash 2143398
 100000000000163cfb1f97c4e4098a3692c8053ad9cab5ad9c86b338b5c00b8b7
 2# bin/bitcoin-cli -testnet getblockheader 00000000000163cfb1f97c4e4098a3692c8053ad9cab5ad9c86b338b5c00b8b7
 3{
 4  "hash": "00000000000163cfb1f97c4e4098a3692c8053ad9cab5ad9c86b338b5c00b8b7",
 5  "confirmations": 20002,
 6  "height": 2143398,
 7  "version": 536870916,
 8  "versionHex": "20000004",
 9  "merkleroot": "860811ef213234164a47bbdfc412c698fae84a2f9cf045983c7ada7acda6e894",
10  "time": 1644883096,
11  "mediantime": 1644883056,
12  "nonce": 3371479007,
13  "bits": "1c32b240",
14  "difficulty": 5.049602219097336,
15  "chainwork": "00000000000000000000000000000000000000000000064728c7be6fe4b2f961",
16  "nTx": 1,
17  "previousblockhash": "00000000000151e849c468a1861b4683f81fccdbd84b555ccba31ca34212c6c5",
18  "nextblockhash": "000000001b45803f50e27a283c8575bf159add02c971f9602608d54d688c7798"
19}
  10. laanwj commented at 3:22 pm on February 23, 2022: member

    @sdaftuar Thanks!

    My testnet data (I just used the current tip – should I go back a few weeks?)

    The release process mentions “Testnet should be set some tens of thousands back from the tip due to reorgs there” for nMinimumChainWork and defaultAssumeValid specifically, not the other stats. I don’t know how relevant this still is.

  11. ghost commented at 3:36 pm on February 23, 2022: none

    Testnet

    m_assumed_blockchain_size and m_assumed_chain_state_size

     0du | Sort-Object -Property "Size(MB)" -Descending
 1
 2Name                 Size(MB)
 3----                 --------
 4blocks               29594.67
 5indexes               3608.49
 6chainstate            1408.83
 7tor                     10.44
 8debug.old.log           10.03
 9debug.log                9.26
10wallet.dat                2.2
11database                    2
12peers.dat                0.48
13fee_estimates.dat        0.24

    chainTxData

     0getchaintxstats
 1
 2{
 3  "time": 1645636320,
 4  "txcount": 62226436,
 5  "window_final_block_hash": "00000000cdec5e424755bc1c05d7c410816e67df14112b383a642823f8efc647",
 6  "window_final_block_height": 2163399,
 7  "window_block_count": 4320,
 8  "window_tx_count": 45780,
 9  "window_interval": 592666,
10  "txrate": 0.07724418137703191
11}

    nMinimumChainWork and defaultAssumeValid

     0getblockhash 2113399
 1
 200000000004d479629eed9a48bb26018e9ee2cd96c27e1671b5e1912af50b55a
 3
 4getblockheader 00000000004d479629eed9a48bb26018e9ee2cd96c27e1671b5e1912af50b55a
 5
 6{
 7  "hash": "00000000004d479629eed9a48bb26018e9ee2cd96c27e1671b5e1912af50b55a",
 8  "confirmations": 50001,
 9  "height": 2113399,
10  "version": 549453824,
11  "versionHex": "20c00000",
12  "merkleroot": "58f843b066e6a924ba5d9b09486547b3aea5dc5ae26af7c8b7598c7cb729d769",
13  "time": 1639108042,
14  "mediantime": 1639108033,
15  "nonce": 1736346435,
16  "bits": "1c03fffc",
17  "difficulty": 64,
18  "chainwork": "00000000000000000000000000000000000000000000061eff7f8ad70d987929",
19  "nTx": 1,
20  "previousblockhash": "0000000000a9f4e47cfb6984eee25f146123db1a752eeed428417e369a55bc69",
21  "nextblockhash": "00000000007ad25fa0d4835e2bc0cce5272933a7438262a7d616874d3d76732a"
22}
  12. laanwj commented at 3:51 pm on February 23, 2022: member

    Signet:

    0$ du -h
156M     ./chainstate
24.0K    ./wallets
313M     ./blocks/index
4388M    ./blocks
5453M    .

     0$ src/bitcoin-cli -signet getchaintxstats 4096
 1{
 2  "time": 1645631279,
 3  "txcount": 1257429,
 4  "window_final_block_hash": "0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09",
 5  "window_final_block_height": 78789,
 6  "window_block_count": 4096,
 7  "window_tx_count": 338057,
 8  "window_interval": 2432697,
 9  "txrate": 0.1389638742514995
10}

     0$ src/bitcoin-cli -signet getblockhash 78788
 100000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef
 2$ src/bitcoin-cli -signet getblockheader 00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef
 3{
 4  "hash": "00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef",
 5  "confirmations": 2,
 6  "height": 78788,
 7  "version": 536870912,
 8  "versionHex": "20000000",
 9  "merkleroot": "1ab0ba555287a8e81d9a2917d92d7c4a985f6cf455ae155dadaa9b66c80719dc",
10  "time": 1645631237,
11  "mediantime": 1645624966,
12  "nonce": 23153229,
13  "bits": "1e015f73",
14  "difficulty": 0.002845317866312478,
15  "chainwork": "000000000000000000000000000000000000000000000000000000de26b0e471",
16  "nTx": 8,
17  "previousblockhash": "000000b34d7f0abb0f4b15c59f7fc8d1c646322189cd0450fdbdbe74db75916b",
18  "nextblockhash": "0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09"
19}
  13. laanwj force-pushed on Feb 23, 2022
  14. in src/chainparams.cpp:95 in 4f87a2d32f outdated 
    90@@ -91,8 +91,8 @@ class CMainParams : public CChainParams {
91         consensus.vDeployments[Consensus::DEPLOYMENT_TAPROOT].nTimeout = 1628640000; // August 11th, 2021
92         consensus.vDeployments[Consensus::DEPLOYMENT_TAPROOT].min_activation_height = 709632; // Approximately November 12th, 2021
93 
94-        consensus.nMinimumChainWork = uint256S("0x00000000000000000000000000000000000000001fa4663bbbe19f82de910280");
95-        consensus.defaultAssumeValid = uint256S("0x00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad"); // 691719
96+        consensus.nMinimumChainWork = uint256S("0x00000000000000000000000000000000000000002927cdceccbd5209e81e80db");
97+        consensus.defaultAssumeValid = uint256S("0x000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091"); // 724466
    sdaftuar commented at 4:24 pm on February 23, 2022:
    ACK 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091 (assume valid block hash)
  15. in src/chainparams.cpp:222 in 4b3ec86d3f outdated 
    218@@ -219,7 +219,7 @@ class CTestNetParams : public CChainParams {
219         pchMessageStart[3] = 0x07;
220         nDefaultPort = 18333;
221         nPruneAfterHeight = 1000;
222-        m_assumed_blockchain_size = 40;
223+        m_assumed_blockchain_size = 65;
    achow101 commented at 5:22 pm on February 23, 2022:

    In 4b3ec86d3f7436780040619c41ef659f1e7cf8ec " Update m_assumed_* chain parameters for 23.x"

    My testnet node has 29 GB for it’s blocksdir, so perhaps this does not need updating?

    laanwj commented at 11:14 am on February 24, 2022:
    Same for sdaftuar. Huh, did I update the wrong value here.
    laanwj commented at 11:15 am on February 24, 2022:

    Nonono m_assumed_blockchain_size is not for the blocks dir, this is for the entire testnet dir (yes, the name is confusing, but see the release process). For him this was 59G. I added ~10% future overhead on top, rounding to 65GB. This should be correct.

    Edit: Wait, what is so big that is not blocks or chainstate. That leaves space for a really big wallet and log file.

    achow101 commented at 5:42 pm on February 24, 2022:

    Oh, I thought because have m_assumed_chain_state_size that m_assumed_blockchain_size would exclude the chainstate dir.

    Even so, it’s only 35 GB for me and that includes all indexes and other wallets too.

  16. achow101 commented at 5:27 pm on February 23, 2022: member
    ACK 4f87a2d32f2018406f4a70d5256d635ba51696a9
  17. jamesob commented at 9:21 pm on February 23, 2022: member

    ACK https://github.com/bitcoin/bitcoin/pull/24418/commits/4f87a2d32f2018406f4a70d5256d635ba51696a9

    Only checked mainnet:

     0% rpc getblockhash 724466
 1000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
 2
 3% rpc getchaintxstats 4096 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091
 4{
 5  "time": 1645542140,
 6  "txcount": 712531200,
 7  "window_final_block_hash": "000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091",
 8  "window_final_block_height": 724466,
 9  "window_block_count": 4096,
10  "window_tx_count": 6950257,
11  "window_interval": 2404071,
12  "txrate": 2.891036496010309
13}
  18. laanwj commented at 11:36 am on February 24, 2022: member

    I think the most important thing still to test here is, especially for mainnet’s nMinimumChainWork and defaultAssumeValid update:

    This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect that causes rejection of blocks in the past history.

    I did not check this, not sure anyone else did.

  19. jonatack commented at 11:55 am on February 24, 2022: member

    I think the most important thing still to test here is, especially for mainnet’s nMinimumChainWork and defaultAssumeValid update:

    This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect that causes rejection of blocks in the past history.

    Launched it. Might take awhile.

  20. laanwj commented at 11:59 am on February 24, 2022: member

    Launched it. Might take awhile.

    Thanks!

    Edit: re-pushed with the testnet assumed blockchain size change undone.

  21. Update m_assumed_* chain parameters for 23.x 
    - `m_assumed_chain_state_size` doesn't seem to need to be changed for mainnet.
- No change needed for testnet/signet.

Co-authored-by: Suhas Daftuar <sdaftuar@gmail.com>
    37282dcf78
  22. laanwj force-pushed on Feb 24, 2022
  23. in src/chainparams.cpp:264 in dbbacb2ac8 outdated 
    260@@ -261,10 +261,10 @@ class CTestNetParams : public CChainParams {
261         };
262 
263         chainTxData = ChainTxData{
264-            // Data from RPC: getchaintxstats 4096 0000000000004ae2f3896ca8ecd41c460a35bf6184e145d91558cece1c688a76
265-            /* nTime    */ 1625727096,
266-            /* nTxCount */ 60408943,
267-            /* dTxRate  */ 0.08379062270367649,
268+            // Data from RPC: getchaintxstats 4096 00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e
    Sjors commented at 2:14 pm on February 24, 2022:
    Why not use the assumed valid block for this?
    laanwj commented at 2:34 pm on February 24, 2022:
    Sure, why not, I don’t know. If you have other requirements, please update the release process. I’m done with this for this release.
    Sjors commented at 2:47 pm on February 24, 2022:
    It’s probably easier for new reviewers, we can indeed do that for that for the next release.
    laanwj commented at 3:22 pm on February 24, 2022:
    Agree.
    jonatack commented at 1:50 pm on February 28, 2022:
    “Testnet should be set with a height some tens of thousands back from the tip, due to reorgs there” (release-process.md) -> would that apply only for updating nMinimumChainWork then?
  24. in src/chainparams.cpp:294 in dbbacb2ac8 outdated 
    295             chainTxData = ChainTxData{
296-                // Data from RPC: getchaintxstats 4096 000000187d4440e5bff91488b700a140441e089a8aaea707414982460edbfe54
297-                /* nTime    */ 1626696658,
298-                /* nTxCount */ 387761,
299-                /* dTxRate  */ 0.04035946932424404,
300+                // Data from RPC: getchaintxstats 4096 0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09
    Sjors commented at 2:16 pm on February 24, 2022:
    Ditto question
  25. Sjors commented at 2:20 pm on February 24, 2022: member

    ACK dbbacb2ac86a996c219477c5797e365112612608 for mainnet and signet, but not testnet

    Why don’t we use the same block for assume-valid and chainTxData on testnet and signet?

    I verified the above values on an existing node, did not do a fresh IBD.

  26. in src/chainparams.cpp:266 in dbbacb2ac8 outdated 
    265-            /* nTime    */ 1625727096,
266-            /* nTxCount */ 60408943,
267-            /* dTxRate  */ 0.08379062270367649,
268+            // Data from RPC: getchaintxstats 4096 00000000d18cfe81cbeea665076807789bd8f831d557632e635bc6e3c003069e
269+            /* nTime    */ 1645635119,
270+            /* nTxCount */ 44718,
    Sjors commented at 2:59 pm on February 24, 2022:
    This is window_tx_count, txcount is 62226341
    laanwj commented at 3:19 pm on February 24, 2022:
    Good catch! Updated and re-pushed.
  27. Update chainTxData for 23.x 
    Co-authored-by: Suhas Daftuar <sdaftuar@gmail.com>
    85e71a3baa
  28. Update nMinimumChainWork, defaultAssumeValid for 23.x 
    Co-authored-by: Suhas Daftuar <sdaftuar@gmail.com>
    dca693e08e
  29. in src/chainparams.cpp:296 in dbbacb2ac8 outdated 
    297-                /* nTime    */ 1626696658,
298-                /* nTxCount */ 387761,
299-                /* dTxRate  */ 0.04035946932424404,
300+                // Data from RPC: getchaintxstats 4096 0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09
301+                /* nTime    */ 1645631279,
302+                /* nTxCount */ 1257429,
    Sjors commented at 3:00 pm on February 24, 2022:
    This one is correct.
    jonatack commented at 9:27 pm on February 24, 2022:

    I’m running reindex-chainstate and assumevalid=0 on mainnet/testnet/signet. So far signet has completed. It matches.

     0./src/bitcoin-cli -signet getchaintxstats 4096 0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09
 1{
 2  "time": 1645631279,
 3  "txcount": 1257429,
 4  "window_final_block_hash": "0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09",
 5  "window_final_block_height": 78789,
 6  "window_block_count": 4096,
 7  "window_tx_count": 338057,
 8  "window_interval": 2432697,
 9  "txrate": 0.1389638742514995
10}
  30. laanwj force-pushed on Feb 24, 2022
  31. Sjors commented at 3:38 pm on February 24, 2022: member

    ACK dca693e08e66279c5497cb3d30285ed41ae6983c

     0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA256
 2
 3ACK dca693e08e66279c5497cb3d30285ed41ae6983c
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQIzBAEBCAAdFiEE7ZvfetalXiMuhFJCV/+b28wwEAkFAmIXpyYACgkQV/+b28ww
 7EAn0ZxAAn0BJay+iFX30/BbzX4ymp/MRjHlmVDJMgRZxJbFrj3UG1J9l+MTq25TN
 8/2r7MRz4C6LK/Vo5y0nkGagFAyNSnCJq1Sp5sSrPDOwLxh2Oyfcy3HFvNtUa48Gw
 9jQLs3r+TsvnOxZYgvyS2rxn7hQp75DIJNOWiIsfkXFbg9YBsll0yJL0du9m5DGyh
10HVlpMzoGHgcBE5Xmtwo0zoOdLC2VoqrwW1PedA7Gwavi2uvBzTJp0euu1rbtrUKw
11Ly3euZsOmstRN6x2OdPH1K193F5SliD77UDHT5a9EZtsfMB4YvnUfDr/3ojeUgrW
12v65HGk5NGOlRizAqnfEgYTEvja4niB+rK38bnqhx2WOR0eFhaVCMZ8xiPPhnMl4u
13VlsRwMomTlyRGDy347G2KCsANmil672l5dLG++/MDgN/A10FlPtFnh71ysLBBL/b
14NCmzOSnOfQot1fxVqJH7hvk5PkLDfn6t9HpP0B1jUflWCix3NuRnpASUGD0koBcQ
15zzJuymD9UOLr0gKls7OfAS+Xyrf4ochJdnjkdi0wpQOlGZbC6nZpAHE8ITo3KTAK
164iL09n+ycv1p/NJyDdbws8qriioJ9zvpeBs+fhkYLEcu55wMx3JK6h5hr1C9IzHA
17waiZocPYpb4GP0cpSON+fbzNuWWiKrt1B/L3x/hRuQqJE0j/a38=
18=MQ9E
19-----END PGP SIGNATURE-----

    One way to fetch my key:

    0gpg -v --auto-key-locate=clear,wkd --locate-key sjors@sprovoost.nl
  32. unknown approved
  33. unknown commented at 3:50 pm on February 24, 2022: none

    ACK https://github.com/bitcoin/bitcoin/pull/24418/commits/dca693e08e66279c5497cb3d30285ed41ae6983c

    Testnet only (with and without assumevalid re-index-chainstate)

    Agree with @Sjors that we could use assumevalid block for ChainTxData

  34. darosior commented at 4:43 pm on February 24, 2022: member

    ACK dca693e08e66279c5497cb3d30285ed41ae6983c – only checked mainnet (on muliple nodes). Didn’t do a reindex.

     0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3ACK dca693e08e66279c5497cb3d30285ed41ae6983c
 4
 5Block 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091 is in main chain and has 301
 6confirmations at the time of writing. The chain work at this block is 00000000000000000000000000000000000000002927cdceccbd5209e81e80db.
 7-----BEGIN PGP SIGNATURE-----
 8
 9iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmIXtHEACgkQ4T/BRc0/
10QwQ/JgwAxgT+Z+HaRwrmxZDr3xkH8vS6hUWgvOUMsMrJ3Vs9OsbJ/seYRN0QJzTK
11Z30PuQqFKJBa7Jh9TU2EHLW7VHMLfjY+zXZywVQYH4NbDKPlhTlSzdndn84dUV5g
12vKBwzvlDwzvHTTUsiI0zMWduLb67FSTkAL/SUjC3z32UkF1fPj2WwTbgrVFTnI/j
13jTnRmZ+/B1VNWgVmIIqZ8cmUoBPGc8YUb6PM/j6erMPjiWXyesCL2NFEJqJxwRsz
14n4NFOdzizT7ucGvetvhGQCp8OGuTEkDxWOHDsHCl+j0NcyE9ZvM5CGVojSXMQCEq
15RgKjecnRtg+uYPFV1AoJpOIjDELSfrnHZ4PsC+vJ3RBK+fsqAI89Ne0w1zDgSLzc
16Z73twom4OVyIAL9Jv/nVhTm/llq5mgSenh0uszIDLsNgbSsI42zxblIFQ6jgdQYd
17377c/DCDe0CE73ViU/ATbS2VFuTx+C9iU2mAAO/hrOHIGHyVFr6Gha0PPOK3wFn8
18ofJvxRAu
19=viT5
20-----END PGP SIGNATURE-----
  35. achow101 commented at 5:56 pm on February 24, 2022: member
    ACK dca693e08e66279c5497cb3d30285ed41ae6983c
  36. fanquake deleted a comment on Feb 24, 2022
  37. fanquake deleted a comment on Feb 24, 2022
  38. in src/chainparams.cpp:290 in dca693e08e 
    285@@ -286,15 +286,15 @@ class SigNetParams : public CChainParams {
286             vSeeds.emplace_back("178.128.221.177");
287             vSeeds.emplace_back("v7ajjeirttkbnt32wpy3c6w3emwnfr3fkla7hpxcfokr3ysd3kqtzmqd.onion:38333");
288 
289-            consensus.nMinimumChainWork = uint256S("0x0000000000000000000000000000000000000000000000000000008546553c03");
290-            consensus.defaultAssumeValid = uint256S("0x000000187d4440e5bff91488b700a140441e089a8aaea707414982460edbfe54"); // 47200
291+            consensus.nMinimumChainWork = uint256S("0x000000000000000000000000000000000000000000000000000000de26b0e471");
292+            consensus.defaultAssumeValid = uint256S("0x00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef"); // 78788
    jonatack commented at 9:54 pm on February 24, 2022:

    I see the same values for signet with reindex-chainstate and assumevalid=0

     0$ ./src/bitcoin-cli -signet getblockhash 78788
 100000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef
 2
 3$ ./src/bitcoin-cli -signet getblockheader 00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef
 4{
 5  "hash": "00000112852484b5fe3451572368f93cfd2723279af3464e478aee35115256ef",
 6  "confirmations": 166,
 7  "height": 78788,
 8  "version": 536870912,
 9  "versionHex": "20000000",
10  "merkleroot": "1ab0ba555287a8e81d9a2917d92d7c4a985f6cf455ae155dadaa9b66c80719dc",
11  "time": 1645631237,
12  "mediantime": 1645624966,
13  "nonce": 23153229,
14  "bits": "1e015f73",
15  "difficulty": 0.002845317866312478,
16  "chainwork": "000000000000000000000000000000000000000000000000000000de26b0e471",
17  "nTx": 8,
18  "previousblockhash": "000000b34d7f0abb0f4b15c59f7fc8d1c646322189cd0450fdbdbe74db75916b",
19  "nextblockhash": "0000003d9144c56ac110ae04a0c271a0acce2f14f426b39fdf0d938c96d2eb09"
20}
  39. MarcoFalke merged this on Feb 28, 2022
  40. MarcoFalke closed this on Feb 28, 2022
  41. jonatack commented at 11:26 am on February 28, 2022: member

    Launched it. Might take awhile.

    Thanks!

    FWIW after 4 days, I am only at 33% verification progress on mainnet.

  42. Rspigler commented at 5:01 am on March 6, 2022: contributor

    Post-merge ACK with assumevalid=0

    • m_assumed_blockchain_size, m_assumed_chain_state_size

    /.bitcoin$ du -h 105M ./blocks/index 418G ./blocks 4.5G ./chainstate 44K ./v22 Descriptor Compiled Tested 35G ./indexes/txindex 123M ./indexes/coinstats/db 123M ./indexes/coinstats 81M ./indexes/blockfilter/basic/db 7.3G ./indexes/blockfilter/basic 7.3G ./indexes/blockfilter 42G ./indexes 464G . user@Bitcoin:~/.bitcoin$ python3 Python 3.9.2 (default, Feb 28 2021, 17:03:44) [GCC 10.2.1 20210110] on linux Type “help”, “copyright”, “credits” or “license” for more information. 464 * 1.1 510.40000000000003 5 * 1.1 5.5

    I calculated 510G instead of your 460G because I included the optional indexes (txindex, coinstats, and blockfilter). Might want to change in #24424

    • chainTxData

    getchaintxstats 4096 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091 { “time”: 1645542140, “txcount”: 712531200, “window_final_block_hash”: “000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091”, “window_final_block_height”: 724466, “window_block_count”: 4096, “window_tx_count”: 6950257, “window_interval”: 2404071, “txrate”: 2.891036496010309 }

    :heavy_check_mark:

    • nMinimumChainWork, defaultAssumeValid

    getblockhash 724466 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091 getblockheader 000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091 { “hash”: “000000000000000000052d314a259755ca65944e68df6b12a067ea8f1f5a7091”, “confirmations”: 1618, “height”: 724466, “version”: 939515908, “versionHex”: “37ffe004”, “merkleroot”: “35a08d9647972e7c3ec39ee7f4ab434f03445de7c446a4d1acc1254b4546bbbe”, “time”: 1645542140, “mediantime”: 1645539567, “nonce”: 188699556, “bits”: “170a1078”, “difficulty”: 27967152532434.23, “chainwork”: “00000000000000000000000000000000000000002927cdceccbd5209e81e80db”, “nTx”: 1948, “previousblockhash”: “000000000000000000075e26c23c2ecec4e34699411ccd712ff6f2d252f65a78”, “nextblockhash”: “0000000000000000000905369cd69f68323e3e8da2933a78bea0b2cdb8baa89f” }

    :heavy_check_mark:

  43. jonatack commented at 10:14 am on March 7, 2022: member

    I think the most important thing still to test here is, especially for mainnet’s nMinimumChainWork and defaultAssumeValid update:

    This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect that causes rejection of blocks in the past history.

    After 11 days my node completed reindex-chainstate with assumevalid=0 on mainnet and confirms the same result as this pull.

  44. MarcoFalke referenced this in commit 447f50e4ae on Sep 6, 2022
  45. DrahtBot locked this on Mar 7, 2023


laanwj DrahtBot jonatack sdaftuar ghost achow101 jamesob Sjors darosior Rspigler

Labels
Utils/log/libs

Milestone
23.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 00:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me