Bitcoin-Qt: updates to addressbookpage #2443

Diapolo commented at 10:12 AM on April 2, 2013: none

use labelExplanation for sending and receiving tab and move the string from the ui-file to the source
ensure that the table holding the label and address is resized so that the address column fits the address and the label column is stretched to fit the window size
rename some stuff for much easier readbility in the code (I find it hard to get the meaning of stuff like labels or buttons)

laanwj commented at 12:31 PM on April 2, 2013: member

ACK on most changes, but I think you should leave on_XXX_clicked() slots for the automatic signal/slot assignment by Qt designer, otherwise it's pretty confusing. For manual assigned slots, just use lowerCamelCase.

Diapolo commented at 1:31 PM on April 2, 2013: none

@laanwj My fault, I fixed the renaming stuff :). What you observed was a thing I intended to avoid ^^.

BitcoinPullTester commented at 1:34 AM on April 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4e6eefb04bdf15b377b5d23057d29e777134711e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Bitcoin-Qt: updates to addressbookpage

- use labelExplanation for sending and receiving tab and move the string
  from the ui-file to the source
- ensure that the table holding the label and address is resized so that
  the address column fits the address and the label column is stretched to
  fit the window size
- rename some stuff for much easier readbility in the code (I find it hard
  to get the meaning of stuff like labels or buttons)

b9564d7e54

in src/qt/addressbookpage.cpp:None in 4e6eefb04b outdated

  50 | @@ -51,25 +51,26 @@
  51 |      switch(tab)
  52 |      {
  53 |      case SendingTab:
  54 | -        ui->labelExplanation->setVisible(false);
  55 | -        ui->deleteButton->setVisible(true);
  56 | +        ui->labelExplanation->setText(tr("These are your Bitcoin addresses for sending payments. Always check the amount and the receivers address before sending coins."));

laanwj commented at 4:28 PM on April 3, 2013:

Shouldn't that be "Receiving address" instead of "Receivers address" (sorry, not native English either)

Diapolo commented at 8:25 PM on April 3, 2013:

What you say sounds right ^^, will update.

Diapolo commented at 8:32 PM on April 3, 2013: none

@laanwj Updated to receiving address :).

BitcoinPullTester commented at 10:49 PM on April 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b9564d7e541c793a9b9f3f830755d080f595bebc for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj referenced this in commit c19c1d00d9 on Apr 5, 2013

laanwj merged this on Apr 5, 2013

laanwj closed this on Apr 5, 2013

Diapolo deleted the branch on Apr 6, 2013

laudney referenced this in commit 2f31b25ad3 on Mar 19, 2014

DrahtBot locked this on Sep 8, 2021