test: refactor: use `random.sample` for choosing random keys in wallet_taproot.py #24496

The Python3 standard library method random.sample has the exact same functionality as the helper method rand_keys(...) (that is, random sampling without replacement) on a generic set or sequence, i.e. we can simply replace it. See https://docs.python.org/3/library/random.html#random.sample Note that this is also safer: in case that the sample size k is larger than the population count, random.sample throws an error:

$ python3
Python 3.8.12 (default, Sep 26 2021, 13:12:50)
[Clang 11.1.0 ] on openbsd7
Type "help", "copyright", "credits" or "license" for more information.
>>> import random
>>> random.sample([23, 42], 3)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/random.py", line 363, in sample
    raise ValueError("Sample larger than population or is negative")
ValueError: Sample larger than population or is negative

while the custom method would get stuck in an endless loop.

Code Review ACK 31846b006da46852cfce91e53427dc8f871b3fda

I prefer the use of a built-in function over a custom one. The reasons are:

• built-in functions are usually less prone to bugs.
• There’s a standardized way of using the built-in function; hence a code reviewer could easily understand their use case.

And in this case:

• Using built-in function prevents at least one bug, that is:

Note that this is also safer: in case that the sample size k is larger than the population count, random.sample throws an error while the custom method would get stuck in an endless loop.

• Also, it helps remove redundant code from the functional test file and make the file cleaner.

Strong concept ACK

tACK 31846b006da46852cfce91e53427dc8f871b3fda - I prefer to use the random.sample function as, as you said, calling rand_keys(n) with n >= len(KEYS) results in a infinite loop. This change also makes the code cleaner.