doc: update multisig-tutorial.md to descriptor wallet by default #24519

1. 
   jonatack commented at 11:15 am on March 10, 2022: member

   Follow-up to #24281 and #24281 (comment). The default wallet type was changed to descriptor wallets in #23002.
2. fanquake added the label Docs on Mar 10, 2022
3. in doc/multisig-tutorial.md:112 in 4f0573c484 outdated

   108@@ -109,7 +109,7 @@ Then import the descriptors created in the previous step using the `importdescri
   109 After that, `getwalletinfo` can be used to check if the wallet was created successfully.
   110 
   111 ```bash
   112-./src/bitcoin-cli -signet -named createwallet wallet_name="multisig_wallet_01" disable_private_keys=true blank=true descriptors=true
   113+./src/bitcoin-cli -signet -named createwallet "multisig_wallet_01" true true
   

   ---

   ---

   

   laanwj commented at 11:42 am on March 10, 2022:

   I like the named syntax better here. true true doesn’t say much.

   ---

   

   jonatack commented at 11:51 am on March 10, 2022:

   Thanks, I hesitated on this and prefer the named version as well. Done.
4. 
   laanwj commented at 11:43 am on March 10, 2022: member

   Concept ACK on removing descriptors=true.
5. doc: update multisig-tutorial.md to default wallet type 5347c9732f
6. jonatack force-pushed on Mar 10, 2022
7. 
   laanwj commented at 11:59 am on March 10, 2022: member

   Right. In general there is IMO no reason to prefer unnamed to named syntax, or the other way around. Whatever is clearer. In this case, it’s named.

   ACK 5347c9732ff24bfcdcd62d0291972c86c80558dc

8. theStack approved
9. 
   theStack commented at 2:13 pm on March 13, 2022: member

   Concept and code-review ACK 5347c9732ff24bfcdcd62d0291972c86c80558dc

   Slightly related, but certainly not high priority: there are also numerous createwallet RPC calls with descriptors=True in functional tests that where the explicit parameter could also be omitted on the long-term.

10. 
    michaelfolkson commented at 2:26 pm on March 13, 2022: contributor

    ACK 5347c9732ff24bfcdcd62d0291972c86c80558dc

    Improved docs with no need to specify a descriptor wallet given it is default.

    there are also numerous createwallet RPC calls with descriptors=True in functional tests that where the explicit parameter could also be omitted on the long-term

    Not in scope for this PR but could be omitted in additional PRs now right? Doesn’t need to be long term?

11. 
    theStack commented at 2:54 pm on March 13, 2022: member

    there are also numerous createwallet RPC calls with descriptors=True in functional tests that where the explicit parameter could also be omitted on the long-term

    Not in scope for this PR but could be omitted in additional PRs now right? Doesn’t need to be long term?

    Sure, it can be done immediately. I think this task makes a perfect candidate for a good first issue: #24550

12. 
    jonatack commented at 8:22 pm on March 16, 2022: member

    @achow101 this seems RFM
13. 
    achow101 commented at 8:25 pm on March 16, 2022: member

    ACK 5347c9732ff24bfcdcd62d0291972c86c80558dc
14. achow101 merged this on Mar 16, 2022
15. achow101 closed this on Mar 16, 2022

    ---

16. jonatack deleted the branch on Mar 16, 2022
17. sidhujag referenced this in commit 3163d06a80 on Mar 16, 2022
18. DrahtBot locked this on Mar 16, 2023

Contributors
jonatack laanwj theStack michaelfolkson achow101

Labels
Docs