test: use MiniWallet for feature_maxuploadtarget.py #24533

1. 
   theStack commented at 3:21 pm on March 11, 2022: member

   This PR enables one more of the non-wallet functional tests (feature_maxuploadtarget.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078. Note that the adapted helper function mine_large_block is currently only is used in this test, i.e. there was no need to change any others.
2. test: use MiniWallet for feature_maxuploadtarget.py

   This test can now be run even with the Bitcoin Core wallet disabled.

   aab552fa30
3. DrahtBot added the label Tests on Mar 11, 2022
4. brunoerg approved
5. 
   brunoerg commented at 1:50 pm on March 12, 2022: member

   crACK aab552fa3073f27bcedee1d5890e7e8d9e67ffb4

   I took a look into this test last week to analyse MiniWallet usage, great to see this PR. No problem in modifying mine_large_block since it’s been used only in feature_maxuploadtarget. I just noticed that feature_pruning implements a mine_large_blocks function but it has nothing to do with mine_large_block and the approach seems very different.

6. MarcoFalke merged this on Mar 13, 2022
7. MarcoFalke closed this on Mar 13, 2022

   ---

8. DrahtBot locked this on Mar 13, 2023

Contributors
theStack brunoerg

Labels
Tests