rpc: Split mempool RPCs from blockchain.cpp #24537

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2203-mempoolRpc-🌛 changing 8 files +502 −463

MarcoFalke commented at 4:50 PM on March 11, 2022: member

The blockchain.cpp file is quite large. This makes it harder to navigate and increases the memory required to compile.

Improve on both issues by splitting up the mempool RPCs to a separate file.

rpc: Move mempool RPCs to new file

Can be reviewed with:
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

fa2a5f301a

refactor: Avoid int64_t -> size_t -> int64_t conversion fafd40b541
MarcoFalke force-pushed on Mar 11, 2022
DrahtBot added the label Build system on Mar 11, 2022
DrahtBot added the label RPC/REST/ZMQ on Mar 11, 2022
MarcoFalke removed the label Build system on Mar 11, 2022
MarcoFalke removed the label RPC/REST/ZMQ on Mar 11, 2022
MarcoFalke added the label Refactoring on Mar 11, 2022
MarcoFalke added the label RPC/REST/ZMQ on Mar 11, 2022
DrahtBot commented at 9:41 PM on March 12, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #24513 (CChainState -> Chainstate by jamesob)
- #24408 (rpc: add rpc to get mempool txs spending specific prevouts by t-bast)
- #21422 (Add feerate histogram to getmempoolinfo by kiminuo)
- #19792 (rpc: Add dumpcoinstats by fjahr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
theStack commented at 1:56 PM on March 13, 2022: member

Concept ACK
theStack approved
theStack commented at 12:26 PM on March 15, 2022: member

Code-review ACK fafd40b5413aea5f8ec47c24fdb2ccc702e7cdd7
in src/rpc/blockchain.cpp:2381 in fafd40b541 outdated
```
2376 | @@ -2825,6 +2377,14 @@ UniValue CreateUTXOSnapshot(
2377 |      return result;
2378 |  }
2379 |  
2380 | +
2381 | +RPCHelpMan getmempoolancestors();
```
promag commented at 6:15 PM on March 15, 2022:

nit, create a RegisterMempoolRPCCommands instead.

MarcoFalke commented at 6:40 PM on March 15, 2022:

Thx, done
promag commented at 6:15 PM on March 15, 2022: member

Code review ACK fafd40b5413aea5f8ec47c24fdb2ccc702e7cdd7.
Add RegisterMempoolRPCCommands helper fad4c8934c
promag commented at 6:35 PM on March 15, 2022: member

Code review ACK fad4c8934c7b4342076bd01daa4abf4d83617b17.
theStack approved
theStack commented at 11:04 PM on March 15, 2022: member

Code-review ACK fad4c8934c7b4342076bd01daa4abf4d83617b17 🏞️
MarcoFalke merged this on Mar 16, 2022
MarcoFalke closed this on Mar 16, 2022
MarcoFalke deleted the branch on Mar 16, 2022
sidhujag referenced this in commit 640fa0eed4 on Mar 16, 2022
IsSanicolas referenced this in commit b5cce8f320 on Apr 27, 2022
DrahtBot locked this on Mar 16, 2023

Contributors

Labels

Refactoring RPC/REST/ZMQ

rpc: Split mempool RPCs from blockchain.cpp #24537

Conflicts