guix: make it possible to override gpg binary #24552

1. 
   prusnak commented at 7:03 pm on March 13, 2022: contributor

   For example on Qubes OS one might want to use qubes-gpg-client-wrapper instead

   Fixes https://github.com/bitcoin/bitcoin/issues/24346

2. prusnak force-pushed on Mar 13, 2022
3. DrahtBot added the label Build system on Mar 13, 2022
4. DrahtBot added the label Scripts and tools on Mar 13, 2022
5. 
   JeremyRand commented at 6:45 am on March 14, 2022: contributor

   Concept ACK. Regarding the lint failure about not quoting the new variable, I am unsure whether this lint failure is actually a problem. It seems to me that some users may wish to pass extra arguments to whatever executable is used in place of gpg; quoting the variable would prevent this use case. Thoughts?
6. 
   prusnak commented at 9:18 am on March 14, 2022: contributor

   It seems to me that some users may wish to pass extra arguments to whatever executable is used in place of gpg; quoting the variable would prevent this use case.

   If we want to enable passing the extra arguments, we’d need to do the following change, so the check_tools correctly extracts the binary name and checks against that.

   0- check_tools ${GPG}
   1+ GPG_ARRAY=($GPG)
   2+ check_tools "${GPG_ARRAY[0]}"
   

   If we want to disable passing the extra arguments, it’s enough to just quote the variable usage, right.

   I will wait for resolution which way we want to go and then I’ll update the PR.

7. 
   JeremyRand commented at 10:52 am on March 14, 2022: contributor

   I have a weak preference for allowing extra arguments, but I do not have any immediate need for it myself, so will defer if anyone else has a good reason not to.
8. prusnak force-pushed on Mar 14, 2022
9. 
   prusnak commented at 1:54 pm on March 14, 2022: contributor

   I have a weak preference for allowing extra arguments

   Applied the improvement from #24552 (comment) in e368c03e6eee2d25f4db6af606108a9dc1ca4963

   If there is a consensus we do not want $GPG to contain extra arguments, I will gladly rework the PR

10. prusnak force-pushed on Mar 14, 2022
11. 
    theStack commented at 12:51 pm on March 15, 2022: member

    Concept ACK
12. guix: make it possible to override gpg binary

    For example on Qubes OS one might want to use qubes-gpg-client-wrapper instead

    af74e061c0
13. prusnak force-pushed on Mar 15, 2022
14. 
    laanwj commented at 11:21 am on April 4, 2022: member

    Concept and code review ACK af74e061c052fa8b260ee71bf048fe22028962ae

    I think passing extra arguments to gpg is a valid usecase. Though, as of course always with shell nonsense, this interferes with using spaces in filenames. But that’s probably not too common (sigh)…

15. laanwj merged this on Apr 6, 2022
16. laanwj closed this on Apr 6, 2022

    ---

17. prusnak deleted the branch on Apr 6, 2022
18. sidhujag referenced this in commit 7b911b20b1 on Apr 6, 2022
19. dekm referenced this in commit 9481d49f4a on Oct 27, 2022
20. DrahtBot locked this on Apr 6, 2023

Contributors
prusnak JeremyRand theStack laanwj

Labels
Build system Scripts and tools