small indentation, space, formatting fixes (no code changes) #2456

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:code-layout changing 8 files +39 −42

Diapolo commented at 9:35 AM on April 4, 2013: none

Sorry, but I found some ugly things style-wise after merging the thread/shutdown pull ;).
in src/net.cpp:None in 46d624136e outdated
```
 442 | +    {
 443 | +        LOCK(cs_vNodes);
 444 | +        BOOST_FOREACH(CNode* pnode, vNodes)
 445 | +            if (pnode->addrName == addrName)
 446 | +                return (pnode);
 447 | +    }
```
sipa commented at 11:02 PM on April 5, 2013:

This isn't really necessary - the different between having the return inside or outside the CS is ~nothing.

Diapolo commented at 12:06 AM on April 6, 2013:

Yeah, but all other FindNode() functions have it that way and a new code-reader would perhaps be irritated, like I was ;)?

sipa commented at 12:21 AM on April 6, 2013:

Well feel free to remove it there too, then. Those are likely artifacts from when the macro was LOCK(cs) { ... }, instead of { LOCK(cs); ... }, as a way to avoid changing indentation.

Diapolo commented at 12:24 AM on April 6, 2013:

I'll do this then :).
sipa commented at 11:03 PM on April 5, 2013: member

ACK apart from one nit.
small indentation, space, formatting fixes (no code changes) b001c87126
Diapolo commented at 12:31 AM on April 6, 2013: none

Nit was fixed :).
sipa referenced this in commit 484af4e2d1 on Apr 6, 2013
sipa merged this on Apr 6, 2013
sipa closed this on Apr 6, 2013
Diapolo deleted the branch on Apr 6, 2013
laudney referenced this in commit 2c41da3811 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

sipa