doc: Clarify that CheckSequenceLocksAtTip is a validation function #24564

1. 
   MarcoFalke commented at 3:42 pm on March 14, 2022: member

   It has been pointed out that a bug in this function can prevent block template creation. ( #24080 (comment) ) So it seems that the scope of this function is more than “policy”. Rename it back to “validation”, to partially revert commit fa4e30b0f36f2e7a09db7d30dca9008ed9dbcb35.
2. 
   glozow commented at 3:46 pm on March 14, 2022: member

   Could say “mempool validation helper functions” if your intent is to convey that these are only used for validating transactions being {,re-}added to the mempool.
3. 
   MarcoFalke commented at 3:46 pm on March 14, 2022: member

   An alternative follow-up suggested to use check the sequence locks before including a tx in a template. (https://github.com/bitcoin/bitcoin/pull/24080#issuecomment-1065366812)

   As that requires reading the utxo set, I am not sure about the performance impact. So I’ll leave it for a follow-up.

4. Clarify that CheckSequenceLocksAtTip is a validation function fa86710187
5. MarcoFalke force-pushed on Mar 14, 2022
6. 
   MarcoFalke commented at 3:48 pm on March 14, 2022: member

   Thx, done.
7. DrahtBot added the label Validation on Mar 14, 2022
8. 
   luke-jr commented at 5:28 pm on March 18, 2022: member

   Concept NACK: Block template creation IS mere policy.
9. 
   MarcoFalke commented at 9:09 am on March 19, 2022: member

   Maybe we need a separate word to describe block templates that are consensus invalid? It doesn’t seem policy nor consensus, so I picked “validation”.
10. MarcoFalke added the label Docs on Jun 10, 2022
11. fanquake requested review from glozow on Aug 5, 2022
12. 
    glozow commented at 3:25 pm on August 8, 2022: member

    ACK fa8671018766b2f0e18c94cff3ab2a67c6b3a41d

    I agree this is clearer.

13. glozow requested review from ajtowns on Aug 8, 2022
14. 
    ajtowns commented at 3:28 am on August 9, 2022: contributor

    ACK fa8671018766b2f0e18c94cff3ab2a67c6b3a41d - looks fine to me
15. glozow merged this on Aug 9, 2022
16. glozow closed this on Aug 9, 2022

    ---

17. sidhujag referenced this in commit 89c82d26b8 on Aug 9, 2022
18. MarcoFalke deleted the branch on Aug 10, 2022
19. bitcoin locked this on Aug 10, 2023

Contributors
MarcoFalke glozow luke-jr ajtowns

Review Requested
ajtowns

Labels
Docs Validation