Bitcoin-Qt: full Qt5 support #2457

• re-work included headers and used functions to be fully Qt5 compliant, while maintaining Qt4 compatibility
• also includes some small GUI layout changes (remove hard-coded column sizes)

Below is a screen with the Qt5 Fusion style :).

Let's see if pull-tester is happy with that :).

Hah, finally a reason for me to install qt5 :)

Still waiting for pulltester... ACK from my testing

build is broken on mac because Qt5 5.0.x has no longer platform dependent function. There functions make problem:

• qt_mac_execute_apple_script
• qt_mac_set_dock_menu
• pixmap.toMacCGImageRef()

@jonasschnelli Can you give some more details in which file the compilation fails and what the exact errors are? I can only talk about the Windows build, which should compile just fine.

@Diapolo i try to analyse it more clear and maybe i'm capable to offer you a pull request with some fixes.

Sounds good :). @laanwj Linux doesn't suffer any compilation problems?

should we not create a Qt5 branch for Qt5 support? On the mac side, there are some changes to do:

• testnet (green) doc icon ("switch icon" is broken in Qt5)
• Growl support (needs some code fixes)
• x86 support

My recommendation would be to drop Growl support and add support for the new Notification Center (OSX 10.8+). Growl is no longer opensource and must be purchased. If someone runs <10.8, notifications are not supported.

I have some commits ready to fix certain things. But i'm not sure where i should open the pull request. I think a Qt5 branch in the main repo. would make sense. If not, i can also open a PR at Diapolos repo.

And some screens from mac client with qt5.

@Diapolo btw: your 440BTC balance is nice. :) I have to recover somehow.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fbece27b608e7fe99c02b531735b445b6100fb4f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

@jonasschnelli I think you can base your pull request on this one, as I don't yet know how I could add your pull-request into my repository (was never the case before ^^). But it's rather GREAT, that you are able to help with Mac GUI wise!

I don't think we need a Qt5 branch, as long as Qt4 compatibility is still persistent.

Oh and that BTC is a testnet wallet ^^. I lost all my coins with a scam a few months ago, but I don't care :).

At least @BitcoinPullTester is happy, does he also build Mac binaries? Perhaps not ^^.

Well I'd prefer not to have a separate Qt5 branch. As long as there are no critical issues with Qt4 compatibility, I'd like to merge it.

But it would be possible to do it temporarily...

Pulltester doesn't build on/for Mac at the moment. Cross-building for Mac would be nice but is hard to do, and we don't have any dedicated Mac developers on the dev team.

@laanwj I would also love to see that merged, perhaps @jonasschnelli can then create pulls based on current master :). How far is 0.8.2 away, as we need to fix the Mac stuff after merging it.

Edit: That Mac look is quite nice, but I really fell in love with Fusion ^^.

[misinformation deleted]

@laanwj I think we need to think about translations for that intermediate releases, which are based on own branches then!? But at least this means we can safely pull Qt5 and iron it out for 0.9?

@diapolo I'd be for a "no message changes in intermediate releases" policy, to prevent that from being a problem. And yes, if there are only superficial issues on Mac that can be resolved along the way, nothing wallet-eatingly bad, I think we can merge this (as soon as you've rebased).

Rebased!

Edit: I think that "no message changes in intermediate releases" policy is a good one! Any idea, if this should be written down somewhere?

OK I am sorry to disappoint you but just heard on IRC that we are going to spin off a 0.8.2 from HEAD. Severe case of miscommunication here :(

So, let's make a Qt5 branch, then...

https://github.com/laanwj/bitcoin/tree/Qt5

When you make a pull request, be sure to select branch Qt5 of repository laanwj/bitcoin as target branch. I'll see if I can make it the default there. Thanks.

Edit: it's the default branch on https://github.com/laanwj/bitcoin now.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6be5c36218193395188877980d8175806dcdb257 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

@laanwj So I need to add your remote repo via git remote add laanwj git://github.com/laanwj/bitcoin and push my Qt5 branch to your master via git push origin laanwj/master?

Diapolo: yes to the "remote add", but you can't currently directly push to it; if you have qt5 specific changes you can create pull requests to my repo instead of the main one, so I (or you, when I give you commit access) can merge them there.

(and eventually I'll merge it here upstream all at once, once 0.8.2 is out)

@laanwj How do I create a pull-request via the git command-line? Normally I push to my repo and create a pull-req for Bitcoin master directly via Github website.

Edit: Nevermind I got it, I can chose you as base repo to open pull-requests via Github, so no need to fiddle around with the command-line :D. Currently your branch is up-to date, so nothing to do now.

I am not aware of any method to create a pull request on the command line. Indeed, you can simply push to an own branch and use the github interface :)

As soon as @Diapolo has open a push request on https://github.com/laanwj/bitcoin Qt5 branch and @laanwj has merged, i will create also a PR with my mac QT5 changes.

@laanwj @BitcoinPullTester i think cross-platfrom builds are not possible. The apple frameworks are only available on Mac OSX. I can try to set up a hackintosh on one of my debian-servers with VMWare and give you a jenkins node. How does the pull tester works? Manually executed? Or does the tester search for new PR and auto-tests them?

@jonasschnelli laanwj already has this Qt5 branch in his repo, which is also the master repo. So you can start supplying patches and even I'm allowed to merge them in his repo.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7cb68a5306cf1dcda1011a0d163c0ebdb916cb55 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

One small correction: it's not the master branch in my repo but the Qt5 branch (which is the default branch) that you should send pull requests to.

The last pull-tester has a display problem on win32 - the transaction history tab has all columns collapsed to the left, so only "Address" is showing. They can be expanded, but the column width is not a saved setting and the issue occurs again upon next start.

Pull-tester uses Qt v4.8.2, whereas the last release was built with 4.8.3, and 4.8.4 is out.

(Also tabs are called tabs but they still don't look like tabs...)

This screws up transactions display with Qt4 because resizeSection(..., QHeaderView::ResizeToContents) doesn't behave reasonably...

@luke-jr Can you check if this also happens with Qt 4.8.3 / 4.8.4? AFAIK I never had this problem with the Qt4 version of my local build.

@laanwj AFAIK there were not that many changes to the Qt5 branch or did @jonasschnelli add further commits to your branch? I'm asking in the light how we intend to behave with Qt5 available now as 5.0.2, which seems rather mature.

Yes, there have been further commits to the branch.

It will be merged after 0.8.2 is released.

Superceded by #2721