ci: add ci/scratch dir to .gitignore #24601

pull josibake wants to merge 1 commits into bitcoin:master from josibake:add-ci-scratch-gitignore changing 1 files +2 −0

josibake commented at 11:10 AM on March 17, 2022: member

Not sure if I'm missing some context as to why this isn't already ignored?
DrahtBot added the label Tests on Mar 17, 2022
hebasto commented at 6:30 PM on March 17, 2022: member

Not sure if I'm missing some context as to why this isn't already ignored?

Do you mean running ci/test_run_all.sh locally?

in .gitignore:155 in edc8003c2b outdated

 150 | @@ -151,3 +151,6 @@ osx_volname
 151 |  dist/
 152 |  
 153 |  /guix-build-*
 154 | +
 155 | +# Ignore CI scratch directory

maflcko commented at 9:55 AM on March 18, 2022:

nit: I don't think this needs a comment

josibake commented at 9:58 AM on March 18, 2022: member

Not sure if I'm missing some context as to why this isn't already ignored?

Do you mean running ci/test_run_all.sh locally?

I am running ci/test_run_all.sh locally while working on a PR and was surprised that the scratch directory wasn't already ignored. Was wondering if there was a reason we need it to not be ignored, but seems like no.
josibake force-pushed on Mar 18, 2022
josibake commented at 10:01 AM on March 18, 2022: member

force pushed to remove the comment per @MarcoFalke 's suggestion; git range-diff master edc8003 e10895d
in .gitignore:155 in e10895d8ec outdated
```
 150 | @@ -151,3 +151,5 @@ osx_volname
 151 |  dist/
 152 |  
 153 |  /guix-build-*
 154 | +
 155 | +ci/scratch/
```
hebasto commented at 1:12 PM on March 18, 2022:

nit: Would be more specific:

/ci/scratch/
josibake commented at 1:45 PM on March 18, 2022:

done!
hebasto approved
hebasto commented at 1:12 PM on March 18, 2022: member

ACK e10895d8ec765a432a255a440e80b75983309955
add ci/scratch dir to gitignore 702759588d
josibake force-pushed on Mar 18, 2022
josibake commented at 1:48 PM on March 18, 2022: member

force pushed to add suggestion from @hebasto ; git range-diff master e10895d 7027595
hebasto approved
hebasto commented at 12:53 PM on March 19, 2022: member

re-ACK 702759588d62869321b3359f0716247d8c4a1471, tested on Ubuntu 22.04.
maflcko merged this on Mar 21, 2022
maflcko closed this on Mar 21, 2022
sidhujag referenced this in commit ea6022b3ff on Mar 22, 2022
bitcoin locked this on Mar 21, 2023
josibake deleted the branch on Jan 26, 2024

Contributors

Labels