Allows the test to be run even without a wallet compiled
test: Use MiniWallet in feature_coinstatsindex #24605
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2203-mini-🐧 changing 2 files +40 −39-
MarcoFalke commented at 6:52 PM on March 17, 2022: member
- MarcoFalke renamed this:
2203 mini 🐧
test: Use MiniWallet in feature_coinstatsindex
on Mar 17, 2022 - fanquake added the label Tests on Mar 17, 2022
- MarcoFalke force-pushed on Mar 17, 2022
- MarcoFalke force-pushed on Mar 17, 2022
- MarcoFalke force-pushed on Mar 17, 2022
- MarcoFalke force-pushed on Mar 17, 2022
-
test: Refactor MiniWallet get_utxo helper fab61437f6
-
Use MiniWallet in feature_coinstatsindex fa48ea3067
- MarcoFalke force-pushed on Mar 17, 2022
-
josibake commented at 10:14 AM on March 18, 2022: member
ACK https://github.com/bitcoin/bitcoin/pull/24605/commits/fa48ea3067698954dd6630748964429686d8eaba
nice, thanks for working on this! ran this on my WIP branch and verified it does run deterministically even if the coin selection algorithm is changed. Also re-compiled without the wallet and ran the test :tada:
closing #24570 in favor of this
-
DrahtBot commented at 12:21 PM on March 19, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #24584 ([RFC] wallet: avoid mixing different
OutputTypesduring coin selection by josibake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- #24584 ([RFC] wallet: avoid mixing different
-
ayush933 commented at 3:50 PM on March 20, 2022: contributor
tACK fa48ea3 . The test runs successfully with the wallet disabled.
-
willcl-ark commented at 9:24 PM on March 21, 2022: member
tACK https://github.com/bitcoin/bitcoin/commit/fa48ea3067698954dd6630748964429686d8eaba both with and without wallet compiled in.
Seems like a good win to be able to test this regardless of wallet status. I also enjoyed that it made the test less verbose at the same time, cutting out the create, fund, sign, send sequence.
- MarcoFalke merged this on Mar 22, 2022
- MarcoFalke closed this on Mar 22, 2022
- MarcoFalke deleted the branch on Mar 22, 2022
- sidhujag referenced this in commit 2c35a5a82f on Mar 23, 2022
- luke-jr referenced this in commit 44c8d30083 on May 21, 2022
- luke-jr referenced this in commit 8f25661a24 on May 21, 2022
- Fabcien referenced this in commit 3884184588 on Dec 3, 2022
- DrahtBot locked this on Mar 22, 2023
Contributors
Labels