test: Add diamond-shape prioritisetransaction test #24623

1. 
   MarcoFalke commented at 10:11 am on March 21, 2022: member

   Looks like there is no test for diamonds, only for chains (in mempool_packages.py)
2. fanquake added the label Tests on Mar 21, 2022
3. 
   jessebarton commented at 1:17 am on March 23, 2022: contributor

   Concept ACK fa58577

   Test passed, no issues

   I’m still learning quite a bit, so not sure what else to check for. Looking at the prioritisetransaction function and trying to understand the logic.

   If reviews like this aren’t helpful let me know.

4. MarcoFalke force-pushed on Mar 24, 2022
5. test: Rework create_self_transfer_multi

   * Add fallback for utxos_to_spend if none are provided
   * Refactor a for-loop

   fa450c18db
6. test: Add diamond-shape prioritisetransaction test fa0758e145
7. MarcoFalke force-pushed on Mar 24, 2022
8. 
   MarcoFalke commented at 5:15 pm on March 24, 2022: member

   Rebased for minor rework
9. 
   jamesob commented at 4:34 pm on March 25, 2022: member

   ACK https://github.com/bitcoin/bitcoin/pull/24623/commits/fa0758e1457552e9243bc9663408e88a8cccc8f6

   Nice test! Ran locally. Was this motivated by the oversight in #24364?

10. 
    MarcoFalke commented at 4:45 pm on March 25, 2022: member

    This probably can’t catch #24364 in the current form. I’d suspect there will need to be at least one call to getblocktemplate
11. MarcoFalke merged this on Mar 28, 2022
12. MarcoFalke closed this on Mar 28, 2022

    ---

13. MarcoFalke deleted the branch on Mar 28, 2022
14. sidhujag referenced this in commit ba62e21b86 on Apr 3, 2022
15. DrahtBot locked this on Mar 28, 2023

Contributors
MarcoFalke jessebarton jamesob

Labels
Tests