23.x #24645

pull amogyisabogy1 wants to merge 20 commits into bitcoin:master from bitcoin:23.x changing 26 files +3637 −83
  1. amogyisabogy1 commented at 10:05 PM on March 22, 2022: none

    -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. build: Bump version to 23.0rc1
    Tree-SHA512: f60e9a8379e299fb54ceb4ba2604913532fa69f882d4cb88577102e259c09318e7edec856bfa8959df5c16584f2d78ed29e0c54a80ad82e60846fac6d432620a
    0970d151d7
  3. doc: Generate manual pages for 23.0rc1
    Tree-SHA512: f0d7b08a621194176f49faad17fcdb144ca4c2d67ea9c2b51855c3adc506461020b091acd710acdfbcfe4b515d01929538a1ae64dc40a6edb6f069ef29a6d90d
    5d2b11c7c9
  4. qt: Pull translations for 0.23rc1
    Tree-SHA512: 8366ebbb3603f3f021285f62df75996883458273b24db4e84ff56a3cb56b54cef474f640ea1f48ebc29dbde0593bd78256b9830555a288ba7e4a0a88e07f729e
    440fbe6dba
  5. guix: use same commit for codesigning time-machine
    The time machines should be updated in lockstep.
    
    Github-Pull: #24484
    Rebased-From: 29862bdd402112a98d5da08cb9909bd427b955ad
    0dcbd2ee93
  6. Merge bitcoin/bitcoin#24485: [23.x] guix: use same commit for codesigning time-machine
    0dcbd2ee9334e9f722796cd5255928ac8fdc4da6 guix: use same commit for codesigning time-machine (fanquake)
    
    Pull request description:
    
      The time machines should be updated in lockstep. Backports #24484.
    
      Github-Pull: #24484
      Rebased-From: 29862bdd402112a98d5da08cb9909bd427b955ad
    
    ACKs for top commit:
      hebasto:
        ACK 0dcbd2ee9334e9f722796cd5255928ac8fdc4da6
    
    Tree-SHA512: 831f2d1a0bd92bc6acbe20b0c2e2557f9cc8056034c6975ec6be2cae2eafe584d618b83519623caa81adc434121174e4c56a2df3cc8912352146ac610901bd0f
    cbdfb46b55
  7. test: Add tests for GetArg methods / settings.json type coercion
    Just add tests. No changes to application behavior. Tests will be
    updated in the next commit changing & improving current behavior.
    
    Include a Qt test for GUI startup crash reported by Rspigler in
    https://github.com/bitcoin/bitcoin/issues/24457 caused by GetArg
    behavior that happens if settings.json contains an integer value for any
    of the configuration options which GUI settings can currently clash with
    (-dbcache, -par, -spendzeroconfchange, -signer, -upnp, -natpmp, -listen,
    -server, -proxy, -proxy, -onion, -onion, -lang, and -prune).
    
    Github-Pull: bitcoin/bitcoin#24498
    Rebased-From: 84b0973e35dae63cd1b60199b481e24d54e58c97
    4607f700d0
  8. qt: Avoid crash on startup if int specified in settings.json
    Fix GUI startup crash reported by Rspigler in
    https://github.com/bitcoin/bitcoin/issues/24457 that happens if
    settings.json contains an integer value for any of the configuration
    options which GUI settings can currently clash with (-dbcache, -par,
    -spendzeroconfchange, -signer, -upnp, -natpmp, -listen, -server, -proxy,
    -proxy, -onion, -onion, -lang, and -prune).
    
    Fix is a one-line change in ArgsManager::GetArg.
    
    Github-Pull: bitcoin/bitcoin#24498
    Rebased-From: 5b1aae12ca4a99c6b09349981a4902717a6a5d3e
    7e1b968f61
  9. guix: use latest signapple
    Github-Pull: #24506
    Rebased-From: 6e9308c6d4ed9fbf909c7234ae31245747183be3
    eba46583ed
  10. build, mac: Include arch in codesignature tarball
    Github-Pull: #24506
    Rebased-From: 0189df1d3171082caf743ef3b0968f43c71303f5
    1fd91da454
  11. Merge bitcoin/bitcoin#24511: [23.x] qt: Avoid crash on startup if int specified in settings.json
    7e1b968f61a1309dfd0fc4f7cd5a2d964bfc4f30 qt: Avoid crash on startup if int specified in settings.json (Ryan Ofsky)
    4607f700d07cd813db4e8ef516b68a759674e1db test: Add tests for GetArg methods / settings.json type coercion (Ryan Ofsky)
    
    Pull request description:
    
      Backport of #24498
    
    ACKs for top commit:
      jonatack:
        ACK 7e1b968f61a1309dfd0fc4f7cd5a2d964bfc4f30
    
    Tree-SHA512: efe6ec4361858e50fd524db64141ad3622ecef321b99567da9650575558a9a9bdec0fc43113967cae2f23a1375132eed2d6ebf64d4aa91ac1c5f2f591a26ba74
    430808ab13
  12. Merge bitcoin/bitcoin#24514: [23.x] Second round signapple backports (M1)
    1fd91da45438a803e5dc968bb976fb0fc79f4a72 build, mac: Include arch in codesignature tarball (Andrew Chow)
    eba46583eda59df1dde72b331f45e340818fa34c guix: use latest signapple (Andrew Chow)
    
    Pull request description:
    
      This backports additional signapple and macOS codesigning changes from #24506 for 23.x (skipping #24503, which is an interim signapple update, and the certvalidator change, which is not strictly necessary), and should complete the changes required to perform M1 codesigning for the 23.x release.
    
    ACKs for top commit:
      hebasto:
        ACK 1fd91da45438a803e5dc968bb976fb0fc79f4a72, I have reviewed the code and it looks OK, I agree it can be merged.
    
    Tree-SHA512: 55b7e0680058203744dc491da060ef56a880270a01c10e475b7a171457902410806895dbe7332a323ce47c2a776337fa29eb811d2511fce84ede13aeacbe2a02
    2bd5fdbced
  13. build: Bump to 23.0rc2
    Tree-SHA512: 6432a93c0f7cca96e548b1a12958b5812621b74c05de581b94fe6a2b2f5958c42bdbc6c1bbe0ab34829d3942784fc811d270fb95b6f64b8228d4b3ec4ccc163f
    60ca24a506
  14. doc: Update manual pages for rc2
    Tree-SHA512: c0ded71cf1dc0b0727f7b87ad353b149fd0c53fdcccf6c058bbcaf3d4bdbf70290b3296f3a93af6f442cbcb1a007f4f8784941fdfd930e389dc5a229c6ee632a
    71866d8566
  15. Update signapple for platform identifier fix
    Github-Pull: #24573
    Rebased-From: 3c74f775ac956de4da4fc076b2360b687531cd63
    de528793b6
  16. guix: Use $HOST instead of generic osx{64} for macOS artifacts
    Github-Pull: #24549
    Rebased-From: 933a43018f0f1c0b72acbfa9de5e0f84bf49d0a2
    7f6420c833
  17. guix: Drop "-signed" suffix for signed macOS .dmg files
    This change makes naming of the signed artifacts consistent across
    different OSes, including Windows.
    
    Github-Pull: #24549
    Rebased-From: 4b4b04a66d8f088f6aa9ec6398db49d40481910f
    2e7cde8f68
  18. guix: Use "win64" for Windows artifacts consistently
    Github-Pull: #24549
    Rebased-From: 53dd6165b8994301d638298906b006032e0bbe48
    dd2c7f71fd
  19. doc: Drop a note about Intel-based Macs
    Github-Pull: #24588
    Rebased-From: e359ba6b35edebf02b968fe60cae48473ed88826
    f541a252f6
  20. doc, guix: Include arm64-apple-darwin into codesigned archs
    Github-Pull: #24597
    Rebased-From: 1f4801b6b197657b81daba52ef62c146fc6bd584
    61c021605f
  21. Merge bitcoin/bitcoin#24593: [23.x] macOS / build backports
    61c021605f8733891cb8d92509c84ac814d3712a doc, guix: Include arm64-apple-darwin into codesigned archs (Hennadii Stepanov)
    f541a252f676dcdab15654e8b2b83b2dbcee46b3 doc: Drop a note about Intel-based Macs (Hennadii Stepanov)
    dd2c7f71fd0f759d0d724ff182b508fc2db59131 guix: Use "win64" for Windows artifacts consistently (Hennadii Stepanov)
    2e7cde8f6851be73477766bac00c4c922d79370f guix: Drop "-signed" suffix for signed macOS .dmg files (Hennadii Stepanov)
    7f6420c833fe63e51ec094c1484969d29aac415b guix: Use $HOST instead of generic osx{64} for macOS artifacts (Hennadii Stepanov)
    de528793b6912dd657c7197b1a01c2da708f0a1f Update signapple for platform identifier fix (Andrew Chow)
    
    Pull request description:
    
      Backports:
      * #24549
      * #24573
      * #24588
      * #24597
    
    ACKs for top commit:
      laanwj:
        Code review ACK 61c021605f8733891cb8d92509c84ac814d3712a
    
    Tree-SHA512: 023bfe6f1a31cec66f0255fb8e9c186f44a50a900a9f22c65b2da672b413fec7570f0f11626317344b6f91e74610006ffe0e35243af510de1eb8a3ceb8e8d37f
    55a60b9718
  22. fanquake closed this on Mar 22, 2022

  23. fanquake locked this on Mar 22, 2022
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me