test: move-only: Move all generate* tests to a single file #24670

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2203-test-gen-🏻 changing 4 files +91 −107

MarcoFalke commented at 11:08 AM on March 25, 2022: member

Seems a bit overkill to spread tests for the generate* methods over several files. Combining them into a single file has also a nice side-effect of requiring less node (re)starts, which are expensive in valgrind.
test: move-only: Move all generate* tests to a single file
Can be reviewed with --color-moved=dimmed-zebra
0000ff0d6b
fanquake added the label Tests on Mar 25, 2022
theStack commented at 12:33 PM on March 25, 2022: member

Concept ACK
MarcoFalke force-pushed on Mar 25, 2022
brunoerg commented at 1:39 PM on March 25, 2022: member

Strong concept ACK

in test/functional/wallet_disable.py:30 in 0000ff0d6b

  25 | @@ -26,10 +26,6 @@ def run_test (self):
  26 |          x = self.nodes[0].validateaddress('mneYUmWYsuk7kySiURxCi3AGxrAqZxLgPZ')
  27 |          assert x['isvalid'] == True
  28 |  
  29 | -        # Checking mining to an address without a wallet. Generating to a valid address should succeed
  30 | -        # but generating to an invalid address will fail.

glozow commented at 3:46 PM on March 25, 2022:

Review note - this comment has been removed. Imo it's fine since all of the generate tests are with wallet disabled, so the comment doesn't add much value.

glozow commented at 3:47 PM on March 25, 2022: member

utACK 0000ff0d6b2442706a588fd906ebf1adf8ff8226

4 leading zeros, nice.
MarcoFalke merged this on Mar 25, 2022
MarcoFalke closed this on Mar 25, 2022
MarcoFalke deleted the branch on Mar 25, 2022
sidhujag referenced this in commit 28c27d99e7 on Apr 2, 2022
sidhujag referenced this in commit 27565b02cf on Apr 2, 2022
DrahtBot locked this on Mar 25, 2023

Contributors

Labels