test: Check an invalid -i2psam will raise an init error #24687

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-03-add-invalid-proxy-test changing 1 files +6 −0

brunoerg commented at 10:08 PM on March 26, 2022: member

This PR adds test coverage (at feature_proxy.py) for the following init error:

https://github.com/bitcoin/bitcoin/blob/2f0f056e08cd5a1435120592a9ecd212fcdb915b/src/init.cpp#L1791

It starts the node with an invalid -i2psam (-i2psam=invalidhere) and test if it raises an error when initializing.
brunoerg closed this on Mar 26, 2022
ClaraBara22 commented at 10:36 PM on March 26, 2022: none

Looks good to me, thanks
brunoerg renamed this:
~~test: Check an invalid proxy will raise an init error~~
test: Check an invalid -i2psam will raise an init error
on Mar 27, 2022
test: invalid -i2psam will raise an init error 45e67b2695
brunoerg reopened this on Mar 27, 2022
brunoerg force-pushed on Mar 27, 2022
DrahtBot added the label Tests on Mar 27, 2022
dunxen approved

dunxen commented at 5:27 PM on March 27, 2022: contributor

Code review ACK 45e67b2

Tested locally. Test passes with invalid -i2psam value and fails (hangs) as with onion and proxy with valid values.

<details> <summary>PGP Signature</summary>


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Code review ACK 45e67b2

Tested locally. Test passes with invalid `-i2psam` value and fails (hangs) as with onion and proxy with valid values.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEKPWQCxu10aS2ttGp7TVwFShqMz0FAmJAnOYACgkQ7TVwFShq
Mz0z9g/9E2v2pao2/X2cyk6BkZwuFuuH0O5Pbt2votwGJZ17UbE5jbw4Pvk2HsNB
zo8Lp6/XBXYQX9Z6xoRI3oCS/oPFrhKwLlKGwDx71PAkt5URChyli0Q5G/yzZmKX
nAtQoO+kmCaa/wWsc9aspgW9u8jC7O7kWZ201gwZyIlyHDWQlKuLeMqMLBAT6IQ8
8tfXGNg7LAJph0caQ9aCGgwXHikg43Cjh3jpcl9tVcvlGAbrlPs2EBXk8LGPdsRC
SSU0OMUj8Zqrlnqj42unywi2U3r7pQd6sQ7gEaqWQrLsCh/jzOq3tXFzw7ryRuFk
17+ULDOhaUXPLb6zE/YYZI+6XWjuAY2CYZKph0y6mbrcEIwXz4yxX+4eAsbkEHG1
duyzEfnLMw+/8v4ordvyGM39a4gbctF6GaIqh6zUzAQSOBeXYwGhhChcXWstfjVv
7dHlkixJz1v3sc5drIh3Ffbn77RhZrpEmaz2c4HeyeI4HwGXvgTtoK1/anK6GHRG
BCqh3beUUHxy+5qVzva1JyfuVpdzbsbGJIhlr9XTDwx0WELg46GPBYSBS5BbDLSb
WhNlWIB0qVLtKBFZo4nasHYksmX7wtZmrlRyHqugSiBEhx2x1v3SOyrxT+qaC7cU
ED60H+6YXKeVoviIJLuLjqq7sSMxhHKapQJcUZaViQ18qhpug9c=
=rVAT
-----END PGP SIGNATURE-----

</details>

MarcoFalke merged this on Mar 28, 2022
MarcoFalke closed this on Mar 28, 2022
jonatack commented at 9:20 AM on March 28, 2022: member

Post-merge ACK
sidhujag referenced this in commit 69b037afdf on Apr 3, 2022
luke-jr referenced this in commit 2fe908f78a on May 21, 2022
DrahtBot locked this on Mar 28, 2023

Contributors

Labels