Made the readme simplified and explanatory and also the code more understandable #24694

pull johnoseni1 wants to merge 10 commits into bitcoin:master from johnoseni1:master changing 4 files +20 −3
  1. johnoseni1 commented at 11:09 AM on March 28, 2022: none

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. added full explanation to the bitcoin core codes 25e9116f60
  3. added full explanation to the bitcoin core codes 3dcb4b3a16
  4. added full explanation to the bitcoin core codes be2830de67
  5. updated #build-osx.md for mac user, in case of errors 728f8063e5
  6. updated #build-osx.md for mac user, in case of errors af4a838298
  7. updated #build-osx.md for mac user, in case of errors aad4176904
  8. updated #build-osx.md for mac user, in case of errors de96632b93
  9. simplified the #readme.md file for bitcoin core f0951f211b
  10. simplified the wallet/wallet.cpp#1345 file for bitcoin core a18a6d9fcc
  11. Merge branch 'bitcoin:master' into master 6e2f6fc758
  12. fanquake closed this on Mar 28, 2022

  13. johnoseni1 commented at 11:31 AM on March 28, 2022: none

    can you let me know why my pull request was closed?

  14. MarcoFalke commented at 11:34 AM on March 28, 2022: member

    Getting started to contribute to Bitcoin Core

    Setting up your development environment

    New developers are very welcome and needed. There are a lot of open issues of any difficulty waiting to be fixed. However, before you start contributing, familiarize yourself with the Bitcoin Core build system and tests. Refer to the documentation in the repository on how to build Bitcoin Core and how to run the unit and functional tests. Once that is done, you are all set.

    If you need more help getting started, please refer to the following resources:

    Pick something to work on

    If you are looking for useful contributions to help out with, you can

    • Search through the good first issues or the ones that are up for grabs. Some of them might no longer be applicable. So if you are interested, but unsure, you might want to leave a comment on the issue first.
    • Write tests to improve the coverage. Any kind of test is welcome and coverage information can be obtained from a relatively recent coverage report. If you are unsure, don't hesitate to check back first.
    • Help with review and testing. There are easy ones such as the gui and rpc. However, review on any open pull request is welcome. Review will also help you understand the codebase better.
    • Help on meta projects related to Bitcoin Core, such as a high-level performance monitor.
    • Join us on irc and let us know what you are interested in.
  15. MarcoFalke commented at 11:36 AM on March 28, 2022: member

    @johnoseni1 The changes here seem random and inconsequential. Make sure to read our contributor workflow (see previous comment) and ensure that each commit has a clear rationale and motivation.

  16. johnoseni1 commented at 11:38 AM on March 28, 2022: none

    Okay sir, just learnt by experience, will fix an issues today again, hoping I don’t get a closed PR

    On Mon, 28 Mar 2022 at 12:36 pm, MacroFake @.***> wrote:

    @johnoseni1 https://github.com/johnoseni1 The changes here seem random and inconsequential. Make sure to read our contributor workflow (see previous comment) and ensure that each commit has a clear rationale and motivation.

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/24694#issuecomment-1080541732, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASDEY27YI2DX333MEGBDYVDVCGKUTANCNFSM5R2Y42IQ . You are receiving this because you were mentioned.Message ID: @.***>

  17. DrahtBot locked this on Mar 28, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me