build, test: Fix test logfile name #24715

1. 
   hebasto commented at 10:19 am on March 30, 2022: member

   Recently merged bitcoin/bitcoin#19385 was flawed as it tries to cat a non-existed logfile:

   • #19385 (review)
   • #19385 (comment)

   Closes bitcoin/bitcoin#17224.

2. build, test: Fix test logfile name

   Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>

   dc0774cbdf
3. build, refactor: Replace tabs with spaces 8b517fae7e
4. 
   hebasto commented at 10:25 am on March 30, 2022: member

   Note for reviewers

   To test this PR, break any test, for instance:

    0--- a/src/test/amount_tests.cpp
    1+++ b/src/test/amount_tests.cpp
    2@@ -26,7 +26,7 @@ BOOST_AUTO_TEST_CASE(GetFeeTest)
    3 
    4     feeRate = CFeeRate(0);
    5     // Must always return 0
    6-    BOOST_CHECK_EQUAL(feeRate.GetFee(0), CAmount(0));
    7+    BOOST_CHECK_EQUAL(feeRate.GetFee(0), CAmount(1));
    8     BOOST_CHECK_EQUAL(feeRate.GetFee(1e5), CAmount(0));
    9 
   10     feeRate = CFeeRate(1000);
   

   and make check twice – in-tree and out-of-tree.

5. DrahtBot added the label Build system on Mar 30, 2022
6. luke-jr approved
7. 
   luke-jr commented at 11:12 pm on March 30, 2022: member

   utACK 8b517fae7eb229911a5d41bbe26fbf6cc7de46df

   (No opinion on reformatting)

8. MarcoFalke merged this on Mar 31, 2022
9. MarcoFalke closed this on Mar 31, 2022

   ---

10. hebasto deleted the branch on Mar 31, 2022
11. sidhujag referenced this in commit 5e7cf64a5c on Apr 3, 2022
12. achow101 referenced this in commit 243d7bde78 on Aug 11, 2022
13. DrahtBot locked this on Mar 31, 2023

Contributors
hebasto luke-jr

Labels
Build system