build, test: Fix test logfile name #24715

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:220330-testlog changing 1 files +12 −12

hebasto commented at 10:19 AM on March 30, 2022: member
Recently merged bitcoin/bitcoin#19385 was flawed as it tries to cat a non-existed logfile:
- #19385 (review)
- #19385 (comment)
Closes bitcoin/bitcoin#17224.

build, test: Fix test logfile name

Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>

dc0774cbdf

build, refactor: Replace tabs with spaces 8b517fae7e

hebasto commented at 10:25 AM on March 30, 2022: member

Note for reviewers

To test this PR, break any test, for instance:

--- a/src/test/amount_tests.cpp
+++ b/src/test/amount_tests.cpp
@@ -26,7 +26,7 @@ BOOST_AUTO_TEST_CASE(GetFeeTest)
 
     feeRate = CFeeRate(0);
     // Must always return 0
-    BOOST_CHECK_EQUAL(feeRate.GetFee(0), CAmount(0));
+    BOOST_CHECK_EQUAL(feeRate.GetFee(0), CAmount(1));
     BOOST_CHECK_EQUAL(feeRate.GetFee(1e5), CAmount(0));
 
     feeRate = CFeeRate(1000);

and make check twice -- in-tree and out-of-tree.

DrahtBot added the label Build system on Mar 30, 2022
luke-jr approved
luke-jr commented at 11:12 PM on March 30, 2022: member

utACK 8b517fae7eb229911a5d41bbe26fbf6cc7de46df

(No opinion on reformatting)
MarcoFalke merged this on Mar 31, 2022
MarcoFalke closed this on Mar 31, 2022
hebasto deleted the branch on Mar 31, 2022
sidhujag referenced this in commit 5e7cf64a5c on Apr 3, 2022
achow101 referenced this in commit 243d7bde78 on Aug 11, 2022
DrahtBot locked this on Mar 31, 2023

Contributors

hebasto

luke-jr

Labels

Build system

Linked (view graph)

#19385 test: Change default test logging directory #25798 build: fix cleanup of test logs