23.0: rc4 backport #24725

pull MarcoFalke wants to merge 2 commits into bitcoin:23.x from MarcoFalke:2203-23rc4-🏅 changing 4 files +16 −7

MarcoFalke commented at 5:01 PM on March 31, 2022: member

No description provided.
MarcoFalke force-pushed on Mar 31, 2022

wallet, refactor: Add wallet::NotifyWalletLoaded() function

This change is a prerequisite for the following bugfix.

Github-Pull: bitcoin/bitcoin#24711
Rebased-From: aeee419c6aae085cacd75343c1ce23486b2b8916

4f3ba8517a

wallet: Postpone NotifyWalletLoaded() for encrypted wallets

Too early NotifyWalletLoaded() call in CWallet::Create() results the
notification goes before DescriptorScriptPubKeyMans were created and
added to an encrypted wallet.

Co-authored-by: Andrew Chow <achow101-github@achow101.com>

Github-Pull: bitcoin/bitcoin#24711
Rebased-From: 0c12f0116ca802f55f5ab43e6c4842ac403b9889

1448c99380

MarcoFalke force-pushed on Mar 31, 2022
laanwj added the label Backport on Mar 31, 2022
Sjors commented at 5:37 PM on March 31, 2022: member

ACK 1448c99380bbb83f2cf0410470e75049d0e0c627
hebasto approved
hebasto commented at 5:48 PM on March 31, 2022: member

ACK 1448c99380bbb83f2cf0410470e75049d0e0c627

Made backports locally without conflicts, having zero diff with this PR branch.
jarolrod commented at 2:28 AM on April 1, 2022: member

ACK https://github.com/bitcoin/bitcoin/commit/1448c99380bbb83f2cf0410470e75049d0e0c627

Also made local back ports, zero-diff
MarcoFalke merged this on Apr 1, 2022
MarcoFalke closed this on Apr 1, 2022
MarcoFalke deleted the branch on Apr 1, 2022
DrahtBot locked this on Apr 1, 2023

Contributors

Labels