test: Fix intermittent test failure in wallet_listreceivedby.py #24739

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2204-test-fail-🍰 changing 1 files +2 −5

MarcoFalke commented at 1:22 PM on April 1, 2022: member
- Remove not needed "Generate block to get out of IBD"
- Sync blocks where possible to avoid incoming blocks on the p2p msghand thread while blocks are mined in the RPC thread. See #24730 for discussion.
test: Fix intermittent test failure in wallet_listreceivedby.py fa1f6df21e
fanquake added the label Tests on Apr 1, 2022
in test/functional/wallet_listreceivedby.py:175 in fa1f6df21e
```
 168 | @@ -172,7 +169,7 @@ def run_test(self):
 169 |          address = self.nodes[0].getnewaddress(label)
 170 |  
 171 |          reward = Decimal("25")
 172 | -        self.generatetoaddress(self.nodes[0], 1, address, sync_fun=self.no_op)
```
mjdietzx commented at 4:53 PM on April 4, 2022:

What was the purpose of this in the first place? Was there any reason to have this?

MarcoFalke commented at 6:31 AM on April 5, 2022:

No idea. I think it was added in b5696750a925c07261287b043ffdfb393cbb1327. It is only needed for the last call to generate IIUC.
mjdietzx commented at 4:54 PM on April 4, 2022: contributor

Concept ACK, I noticed this error on a recent CI run for one of my PRs
MarcoFalke merged this on Apr 27, 2022
MarcoFalke closed this on Apr 27, 2022
MarcoFalke deleted the branch on Apr 27, 2022
sidhujag referenced this in commit 0b6f2ffe8c on Apr 29, 2022
DrahtBot locked this on Apr 27, 2023

Contributors

Labels