test: use MiniWallet for mempool_unbroadcast.py #24749

1. 
   ayush933 commented at 8:49 pm on April 3, 2022: contributor

   This PR enables one of the non-wallet functional tests (mempool_unbroadcast.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078 .
2. DrahtBot added the label Tests on Apr 3, 2022
3. in test/functional/mempool_unbroadcast.py:41 in a89cad1ac9 outdated

   58         rpc_tx_hsh = node.sendrawtransaction(txFS["hex"])
   59 
   60         # check transactions are in unbroadcast using rpc
   61         mempoolinfo = self.nodes[0].getmempoolinfo()
   62-        assert_equal(mempoolinfo['unbroadcastcount'], 2)
   63+        assert_equal(mempoolinfo['unbroadcastcount'], 1)
   

   ---

   ---

   

   MarcoFalke commented at 6:31 am on April 4, 2022:

   I think the test checks that the wallet also submits the tx to the unbroadcast set, so you’d have to still check the removed code paths, conditionally on is_wallet_compiled

   ---

   

   ayush933 commented at 1:44 pm on April 4, 2022:

   Done.
4. test: use MiniWallet for mempool_unbroadcast.py

   This test can now be run even with the Bitcoin Core wallet disabled.

   d2ba43fec8
5. ayush933 force-pushed on Apr 4, 2022
6. ayush933 closed this on Apr 5, 2022

   ---

7. ayush933 reopened this on Apr 5, 2022

   ---

8. MarcoFalke approved
9. MarcoFalke merged this on Apr 5, 2022
10. MarcoFalke closed this on Apr 5, 2022

    ---

11. 
    MarcoFalke commented at 12:27 pm on April 5, 2022: member

    The test failure is unrelated an can be ignored. It will be fixed in #24737
12. ayush933 deleted the branch on Apr 5, 2022
13. sidhujag referenced this in commit 7b1ad1fb15 on Apr 5, 2022
14. MarcoFalke referenced this in commit 4c0d1fec16 on Jun 15, 2022
15. sidhujag referenced this in commit 1630aae6a4 on Jun 15, 2022
16. DrahtBot locked this on Apr 6, 2023

Contributors
ayush933 MarcoFalke

Labels
Tests