- also change the word processors to threads in the setgenerate help message
make getgenerate also return genproclimit parameter #2483
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:internal-miner changing 1 files +5 −2-
Diapolo commented at 11:46 AM on April 7, 2013: none
-
4a1fba9351
make getgenerate also return genproclimit parameter
- also change the word processors to threads in the setgenerate help message
-
BitcoinPullTester commented at 12:28 PM on April 7, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4a1fba9351142af822550c0f26335a5e55b72e0c for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
sipa commented at 3:48 PM on April 7, 2013: member
Meh, I don't really care about the built-in mining code. Don't object to changing this either.
-
Diapolo commented at 3:56 PM on April 7, 2013: none
I always use it for Testnet mining.
-
jgarzik commented at 3:52 AM on April 8, 2013: contributor
Well,
- I do care about the internal miner, it definitely has several users on testnet
- however, this patch breaks an existing interface
- however, not sure we really care about such breakage
-
gavinandresen commented at 3:34 PM on April 8, 2013: contributor
NACK, I don't like breaking RPC interfaces.
I would ACK adding this information to getmininginfo if it is not already there.
-
jgarzik commented at 4:29 PM on April 8, 2013: contributor
NAK'd, closing. I agree that adding to getmininginfo would be fine.
- jgarzik closed this on Apr 8, 2013
- DrahtBot locked this on Sep 8, 2021