Remove not needed ArithToUint256 roundtrips in tests #24854

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2204-round-💈 changing 3 files +9 −16

MarcoFalke commented at 5:34 PM on April 14, 2022: member

No need to go from arith_uint256->uint256 when a uint256 can be constructed right away.

Remove duplicate static_asserts

One should be enough. Can be reviewed with
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

fa456ccb22

Remove not needed ArithToUint256 roundtrips in tests fad6d4f952
MarcoFalke added the label Refactoring on Apr 14, 2022
laanwj commented at 5:42 PM on April 14, 2022: member

Concept ACK, looks like quite some cleanup is possible around ArithToUint256/UintToArith256.
laanwj commented at 4:04 PM on April 21, 2022: member

Code review ACK fad6d4f952373690ef16ce27b0926c0ab762066a
laanwj merged this on Apr 21, 2022
laanwj closed this on Apr 21, 2022
sidhujag referenced this in commit 49cae5f1e0 on Apr 22, 2022
MarcoFalke deleted the branch on Apr 26, 2022
DrahtBot locked this on Apr 26, 2023

Contributors

Labels