lint: Convert lint-includes.sh to Python #24895

1. 
   Kvaciral commented at 4:24 pm on April 16, 2022: contributor

   A port of test/lint/lint-includes.sh to a Python-script as part of the request of #24783. Checked for output-consistency.
2. DrahtBot added the label Tests on Apr 16, 2022
3. Kvaciral force-pushed on Apr 16, 2022
4. 
   DrahtBot commented at 4:57 am on April 17, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #22417 (util/system: Close non-std fds when execing slave processes by luke-jr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. Kvaciral force-pushed on Apr 18, 2022
6. Kvaciral force-pushed on Apr 18, 2022
7. lint: Convert lint-includes.sh to Python 67b41678c8
8. Kvaciral force-pushed on Apr 19, 2022
9. 
   KevinMusgrave commented at 3:34 am on April 20, 2022: contributor

   Tested ACK 67b41678c8284715c9cf96d6bdbde9a072b7a904

   It matches the old output. Example:

    0Duplicate include(s) in src/bench/addrman.cpp:
    1#include <vector>
    2
    3Duplicate include(s) in src/bench/base58.cpp:
    4#include <array>
    5
    6The following files #include .cpp files:
    7src/bench/base58.cpp:#include <bench/bench.cpp>
    8src/bench/bench_bitcoin.cpp:#include <bench/bench.cpp>
    9src/bench/bench_bitcoin.cpp:#include <clientversion.cpp>
   10
   11A new Boost dependency in the form of "boost/algorithm/cats.hpp" appears to have been introduced:
   12src/bench/block_assemble.cpp:#include <boost/algorithm/cats.hpp>
   13
   14A new Boost dependency in the form of "boost/algorithm/dogs.hpp" appears to have been introduced:
   15src/bench/bech32.cpp:#include <boost/algorithm/dogs.hpp>
   16
   17Please use bracket syntax includes ("#include <foo.h>") instead of quote syntax includes:
   18src/bench/bech32.cpp:#include "vector"
   19src/bench/block_assemble.cpp:#include "crypto/sha256.h"
   

10. MarcoFalke merged this on Apr 20, 2022
11. MarcoFalke closed this on Apr 20, 2022

    ---

12. sidhujag referenced this in commit f38719c942 on Apr 22, 2022
13. DrahtBot locked this on Apr 20, 2023

Contributors
Kvaciral DrahtBot KevinMusgrave

Labels
Tests