A port of test/lint/lint-includes.sh to a Python-script as part of the request of #24783. Checked for output-consistency.
lint: Convert lint-includes.sh to Python #24895
pull Kvaciral wants to merge 1 commits into bitcoin:master from Kvaciral:lint-includes-port changing 2 files +179 −103-
Kvaciral commented at 4:24 PM on April 16, 2022: contributor
- DrahtBot added the label Tests on Apr 16, 2022
- Kvaciral force-pushed on Apr 16, 2022
-
DrahtBot commented at 4:57 AM on April 17, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22417 (util/system: Close non-std fds when execing slave processes by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- Kvaciral force-pushed on Apr 18, 2022
- Kvaciral force-pushed on Apr 18, 2022
-
lint: Convert lint-includes.sh to Python 67b41678c8
- Kvaciral force-pushed on Apr 19, 2022
-
KevinMusgrave commented at 3:34 AM on April 20, 2022: contributor
Tested ACK 67b41678c8284715c9cf96d6bdbde9a072b7a904
It matches the old output. Example:
Duplicate include(s) in src/bench/addrman.cpp: #include <vector> Duplicate include(s) in src/bench/base58.cpp: #include <array> The following files #include .cpp files: src/bench/base58.cpp:#include <bench/bench.cpp> src/bench/bench_bitcoin.cpp:#include <bench/bench.cpp> src/bench/bench_bitcoin.cpp:#include <clientversion.cpp> A new Boost dependency in the form of "boost/algorithm/cats.hpp" appears to have been introduced: src/bench/block_assemble.cpp:#include <boost/algorithm/cats.hpp> A new Boost dependency in the form of "boost/algorithm/dogs.hpp" appears to have been introduced: src/bench/bech32.cpp:#include <boost/algorithm/dogs.hpp> Please use bracket syntax includes ("#include <foo.h>") instead of quote syntax includes: src/bench/bech32.cpp:#include "vector" src/bench/block_assemble.cpp:#include "crypto/sha256.h" - MarcoFalke merged this on Apr 20, 2022
- MarcoFalke closed this on Apr 20, 2022
- sidhujag referenced this in commit f38719c942 on Apr 22, 2022
- DrahtBot locked this on Apr 20, 2023
Contributors
Labels