lint: convert shell locale linter test to Python #24929
pull Eunoia1729 wants to merge 1 commits into bitcoin:master from Eunoia1729:lint-shell-locale-py changing 2 files +67 −25-
Eunoia1729 commented at 5:38 am on April 20, 2022: contributorRefs #24783
-
DrahtBot added the label Tests on Apr 20, 2022
-
Eunoia1729 force-pushed on Apr 20, 2022
-
Kvaciral commented at 12:06 pm on April 20, 2022: contributorThe utf8-encoding-linter fails because of the whitespaces around the
=
inwith open(file_path, 'r', encoding = 'utf-8') as file_obj:
on line 47 -
lint: convert shell locale linter test to Python 2c838cc309
-
Eunoia1729 force-pushed on Apr 20, 2022
-
Eunoia1729 commented at 2:42 pm on April 20, 2022: contributor
The utf8-encoding-linter fails because of the whitespaces around the
=
inwith open(file_path, 'r', encoding = 'utf-8') as file_obj:
on line 47Ahh. Thanks for pointing it out ! Today I learnt that it’s a convention to not use spaces around
=
for keyword arguments. :sweat_smile: -
Eunoia1729 commented at 2:56 pm on April 20, 2022: contributor
Before change:
After change:
-
laanwj commented at 4:22 pm on April 25, 2022: memberCode review ACK 2c838cc309b2e3e1e30344178c17f789381a8b6b
-
laanwj merged this on Apr 25, 2022
-
laanwj closed this on Apr 25, 2022
-
sidhujag referenced this in commit 48bf7571cc on Apr 26, 2022
-
DrahtBot locked this on Apr 25, 2023
Labels
Tests
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 06:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 06:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me