lint: convert shell locale linter test to Python #24929

pull Eunoia1729 wants to merge 1 commits into bitcoin:master from Eunoia1729:lint-shell-locale-py changing 2 files +67 −25
  1. Eunoia1729 commented at 5:38 am on April 20, 2022: contributor
    Refs #24783
  2. DrahtBot added the label Tests on Apr 20, 2022
  3. Eunoia1729 force-pushed on Apr 20, 2022
  4. Kvaciral commented at 12:06 pm on April 20, 2022: contributor
    The utf8-encoding-linter fails because of the whitespaces around the = in with open(file_path, 'r', encoding = 'utf-8') as file_obj: on line 47
  5. lint: convert shell locale linter test to Python 2c838cc309
  6. Eunoia1729 force-pushed on Apr 20, 2022
  7. Eunoia1729 commented at 2:42 pm on April 20, 2022: contributor

    The utf8-encoding-linter fails because of the whitespaces around the = in with open(file_path, 'r', encoding = 'utf-8') as file_obj: on line 47

    Ahh. Thanks for pointing it out ! Today I learnt that it’s a convention to not use spaces around = for keyword arguments. :sweat_smile:

  8. Eunoia1729 commented at 2:56 pm on April 20, 2022: contributor

    Before change: Screenshot from 2022-04-16 13-01-54

    After change: Screenshot from 2022-04-16 13-01-32

  9. laanwj commented at 4:22 pm on April 25, 2022: member
    Code review ACK 2c838cc309b2e3e1e30344178c17f789381a8b6b
  10. laanwj merged this on Apr 25, 2022
  11. laanwj closed this on Apr 25, 2022

  12. sidhujag referenced this in commit 48bf7571cc on Apr 26, 2022
  13. DrahtBot locked this on Apr 25, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me