Add -lboost_chrono to both the qt .pro file and makefile.unix #2493

robbak commented at 11:07 AM on April 9, 2013: contributor

On FreeBSD, I was unable to build any version since the MicroSleep() change (commit 1b43bf0d), which created a dependency on boost_chrono for boost versions above 1.50. This dependency had never been added to either makefile.unix or bitcoin-qt.pro.

This pullreq adds the required -lboost_chrono to both files.

Add -lboost_chrono to both the qt .pro file and makefile.unix 5281f99290

Remove explicit adding of this library for win32 if it is being

being added generally. (Thanks Phillip Kaufmann)

9736430b85

Bitcoin-Qt: remove " - " on empty title in BitcoinGUI::message()

- don't display "Bitcoin - " when no title was supplied but just "Bitcoin"

8d643c90a6

in bitcoin-qt.pro:None in 5281f99290 outdated

 399 | @@ -400,7 +400,7 @@ LIBS += $$join(BOOST_LIB_PATH,,-L,) $$join(BDB_LIB_PATH,,-L,) $$join(OPENSSL_LIB
 400 |  LIBS += -lssl -lcrypto -ldb_cxx$$BDB_LIB_SUFFIX
 401 |  # -lgdi32 has to happen after -lcrypto (see  #681)
 402 |  win32:LIBS += -lws2_32 -lshlwapi -lmswsock -lole32 -loleaut32 -luuid -lgdi32
 403 | -LIBS += -lboost_system$$BOOST_LIB_SUFFIX -lboost_filesystem$$BOOST_LIB_SUFFIX -lboost_program_options$$BOOST_LIB_SUFFIX -lboost_thread$$BOOST_THREAD_LIB_SUFFIX
 404 | +LIBS += -lboost_system$$BOOST_LIB_SUFFIX -lboost_filesystem$$BOOST_LIB_SUFFIX -lboost_program_options$$BOOST_LIB_SUFFIX -lboost_thread$$BOOST_THREAD_LIB_SUFFIX -lboost_chrono$$BOOST_LIB_SUFFIX
 405 |  win32:LIBS += -lboost_chrono$$BOOST_LIB_SUFFIX

Diapolo commented at 12:40 PM on April 9, 2013:

We have that dependency in for Windows :D. You need to remove this one then, if the lib should be available for all OSes.

BitcoinPullTester commented at 3:05 PM on April 11, 2013: none

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/9736430b85d8bc5ce0e742344cf2f525a79c6246 for binaries and test log.

This could happen for one of several reasons:

It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (you can find the patches applied at test-time at http://jenkins.bluematt.me/pull-tester/files/patches/)
It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
It does not build on either Linux i386 or Win32 (via MinGW cross compile)
The test suite fails on either Linux i386 or Win32
The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

qt: don't show rpcconnect command line option in help

GUI can't connect to RPC. Showing this option in the help confuses
people, so remove it.

212b42c623

Use a uint256 for bnChainWork

Every block index entry currently requires a separately-allocated
CBigNum. By replacing them with uint256, it's just 32 bytes extra
in CBlockIndex itself.

This should save us a few megabytes in RAM, and less allocation
overhead.

1657c4bc49

Merge pull request #2513 from laanwj/2013_04_gui_remove_rpcconnect

qt: don't show rpcconnect command line option in help

dce6f42477

Merge pull request #2418 from sipa/uintwork

Use a uint256 for bnChainWork

1b4b463c01

sipa commented at 8:59 PM on April 12, 2013: member

I'm afraid this will have to be conditional on the version of Boost used.

robbak commented at 9:18 PM on April 12, 2013: contributor

Ok. I'll look at this further. Is the reason for the windows inclusion of this library also because of boost library version? On 13/04/2013 6:59 AM, "Pieter Wuille" notifications@github.com wrote:

I'm afraid this will have to be conditional on the version of Boost used.

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/2493#issuecomment-16317293 .

luke-jr commented at 9:30 PM on April 12, 2013: member

Note the pullreq to upgrade boost to 1.53 removed the chronos lib.

Diapolo commented at 11:27 PM on April 12, 2013: none

@luke-jr I know that my dependecy lib pull needs updates to reflect this.

Diapolo commented at 11:27 PM on April 12, 2013: none

@robbak Windows needed the chrono lib because we use Boost 1.50.

robbak commented at 4:50 AM on April 13, 2013: contributor

On 13/04/2013 6:59 AM, "Pieter Wuille" notifications@github.com wrote:

I'm afraid this will have to be conditional on the version of Boost used.

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/2493#issuecomment-16317293 .

Time for a silly question: How do we make this conditional on library version? We aren't doing this anywhere else in the makefile or .pro file, and the documentation doesn't seem to advertise a method.

For my purposes on FreeBSD, I can easily handle this in our port makefile - it's easy to add it to LIBS or QMAKE_LFLAGS until we get an updated boost.

luke-jr commented at 5:38 AM on April 13, 2013: member

This is why automake was invented... :p

laanwj commented at 9:23 AM on April 13, 2013: member

Configure script: #2195 I think we're going to need it.

Merge pull request #2515 from laanwj/2013_04_move_exportbutton

qt: move export button to tabs

f81b67829d

Merge pull request #2492 from Diapolo/Qt_message

Bitcoin-Qt: remove " - " on empty title in BitcoinGUI::message()

ac89a1ebe7

Add -lboost_chrono to both the qt .pro file and makefile.unix e16ab320e2

Remove explicit adding of this library for win32 if it is being

being added generally. (Thanks Phillip Kaufmann)

171bb7212b

Merge branch 'add_boost_chrono_lib' of https://github.com/robbak/bitcoin into add_boost_chrono_lib e622f35d2d

BitcoinPullTester commented at 9:28 AM on April 14, 2013: none

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/e622f35d2d3de667006b9c171928e36911aadef9 for binaries and test log.

This could happen for one of several reasons:

It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in contrib/test-scripts)
It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
It does not build on either Linux i386 or Win32 (via MinGW cross compile)
The test suite fails on either Linux i386 or Win32
The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

robbak commented at 9:34 AM on April 14, 2013: contributor

OK, that was jut me doing a merge. Sorry for the noise.

I'll close this. By the time we have a configuration script, We'll have an updated boost, and will no longer need it.

There is someone else on the mailing list that has had the same problem on a linux variant, too.

Another work-around may be adjusting the code to not use boost_chrone below boost version 5.3. I personally would rather add the lib for boost 5.0~5.3. Maybe a note in the makefile, like the notes we have for other boost versions.

robbak closed this on Apr 14, 2013

DrahtBot locked this on Sep 8, 2021