refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs #24934

In CreateNewBlock (in miner.cpp), inBlock is cleared before addPackageTxs, so inBlock will be empty in the first call to UpdatePackagesForAdded. I saw this brought up in these PR review club logs and there didn't seem to be a definitive answer for why the call is necessary. There's also an old PR where this change was going to be applied, but it got closed.

If addPackageTxs can be called when inBlock is not empty, then maybe a test should be added for that case. All the tests seem to pass with this deletion.

The old PR notes that "This is unnecessary now that priority transaction selection is gone." -- priority transaction selection was removed in #9602 and the line that used to add priority txs was https://github.com/bitcoin/bitcoin/pull/9602/files#diff-6bf9d2e37d503f2f3381cd3a41c26e0b9670f26c2cd4571e98d2af9e3767c1a1L170

Concept ACK 5fb15594e84112f7be35f68a843056006b725a22, thanks for providing the context. Agree this is unnecessary given the rationale in 9cea7e37158aa85119de2c81e93901da9e476ee5.

I saw this brought up in these PR review club

CC @mzumsande

If addPackageTxs can be called when inBlock is not empty, then maybe a test should be added for that case.

Given it's a private member used only by CreateNewBlock, I think it's fine to assume nobody will do this.

Concept ACK

nit: remove mention of the linter from the commit message description and maybe mention above context of the removed priority transaction selection instead.

nit: remove mention of the linter from the commit message description and maybe mention above context of the removed priority transaction selection instead. @mzumsande Done

utACK 7036cf52aa080d2a63993c2298555252d507dd2f

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #25223 ([kernel 2e/n] miner: Make mempool optional, stop constructing temporary empty mempools by dongcarl)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.