Qt Build broken on the Mac #2496

issue gavinandresen opened this issue on April 9, 2013
  1. gavinandresen commented at 6:05 PM on April 9, 2013: contributor

    This code is addressbookpage.cpp is broken:

    ifdef Q_OS_MAC // Icons on push buttons are very uncommon on Mac

    ui->newAddressButton->setIcon(QIcon());
    ui->copyToClipboard->setIcon(QIcon());
    ui->deleteButton->setIcon(QIcon());
    

    endif

  2. ghost assigned laanwj on Apr 9, 2013
  3. jonasschnelli commented at 6:29 PM on April 9, 2013: contributor

    I did a fix on that. But it's in a PullRequest for the Qt5 Mac compatibility in laanwj branch: https://github.com/laanwj/bitcoin/pull/1

    I can also create a PullRequest with the addressbookpage.cpp fixes for the master branch. @laanwj how far are we from merging Qt5 support to the master branch?

  4. jonasschnelli commented at 7:13 PM on April 9, 2013: contributor

    here is the commit as pull request picket out of my pull request to the Qt5 branch on laanwj branch: #2498

    should work with Qt4.8. Can someone confirm? (i'm on Qt5 and rollback is pain)

  5. Diapolo commented at 7:24 PM on April 9, 2013: none

    @jonasschnelli That commit should fix it. The build was broken because of wrong button names that I introduced ;-). Thanks for taking care of some Mac stuff.

  6. L2G commented at 8:05 PM on April 9, 2013: contributor

    @jonasschnelli I have Qt4.8 on Lion and the build with your change seems to work fine for me.

  7. gavinandresen closed this on Apr 9, 2013

  8. MarcoFalke locked this on Sep 8, 2021
Labels

Milestone
0.8.2


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me