Move only: Move TxOrphange tests to orphange_tests.cpp #24968

1. 
   jnewbery commented at 7:42 AM on April 25, 2022: member

   PR #21148 moved the orphan transaction handling functionality from net_processing into its own translation unit txorphanage.cpp. The unit tests for that code should be in its own file rather than mixed with the net_processing unit tests in denialofservive_tests.cpp.

2. [tests] Move TxOrphange tests to orphange_tests.cpp b8f17fbcb4
3. fanquake added the label P2P on Apr 25, 2022
4. fanquake requested review from ajtowns on Apr 25, 2022
5. vincenzopalazzo approved
6. 
   vincenzopalazzo commented at 9:11 AM on April 25, 2022: none

   ACK https://github.com/bitcoin/bitcoin/pull/24968/commits/b8f17fbcb4a98187b16dd4737f4751e0eee94c49

7. 
   DrahtBot commented at 6:08 PM on April 25, 2022: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23352 (test: Extend stale_tip_peer_management test by MarcoFalke)
   • #22702 (Add allocator for node based containers by martinus)
   • #21527 (net_processing: lock clean up by ajtowns)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. MarcoFalke merged this on Apr 26, 2022
9. MarcoFalke closed this on Apr 26, 2022

   ---

10. jnewbery deleted the branch on Apr 26, 2022
11. in src/test/orphanage_tests.cpp:5 in b8f17fbcb4

       0 | @@ -0,0 +1,137 @@
       1 | +// Copyright (c) 2011-2022 The Bitcoin Core developers
       2 | +// Distributed under the MIT software license, see the accompanying
       3 | +// file COPYING or http://www.opensource.org/licenses/mit-license.php.
       4 | +
       5 | +#include <arith_uint256.h>
    

    ---

    ---

    

    MarcoFalke commented at 8:25 AM on April 26, 2022:

    iwyu (@fanquake) will fix this, but for completeness I wanted to mention that you partially reverted 173c79626867e9f89d49be7dcbb0c2042c480553

12. sidhujag referenced this in commit bed8e9ccb8 on Apr 26, 2022
13. DrahtBot locked this on Apr 26, 2023

Review Requested
ajtowns