scripted-diff: rename BytePtr to AsBytePtr #24989

pull promag wants to merge 1 commits into bitcoin:master from promag:rename-byteptr changing 4 files +14 −14

promag commented at 8:43 AM on April 26, 2022: member
Building with iPhoneOS SDK fails because it also has BytePtr defined in /usr/include/MacTypes.h:
```
typedef UInt8 *                         BytePtr;
```

scripted-diff: rename BytePtr to AsBytePtr

Building with iPhoneOS SDK fails because it also has `BytePtr` defined 
in /usr/include/MacTypes.h.

-BEGIN VERIFY SCRIPT-
sed -i 's/BytePtr/AsBytePtr/' $(git grep -l "BytePtr" src)
-END VERIFY SCRIPT-

bae4561938

promag commented at 8:44 AM on April 26, 2022: member

@MarcoFalke @sipa feedback is welcomed.
DrahtBot added the label Refactoring on Apr 26, 2022
DrahtBot added the label Wallet on Apr 26, 2022
MarcoFalke commented at 10:38 AM on April 26, 2022: member

cr ACK bae4561938f66b31420ffc3f09c9a62932355b8c
MarcoFalke removed the label Wallet on Apr 26, 2022
laanwj commented at 12:57 PM on April 26, 2022: member

Code review ACK bae4561938f66b31420ffc3f09c9a62932355b8c Besides working around the MacOS problem it simply is a better name, imo.
DrahtBot commented at 2:37 PM on April 26, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #24914 (wallet: Load database records in a particular order by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
prusnak approved
prusnak commented at 3:10 PM on April 26, 2022: contributor

Approach ACK bae4561938f66b31420ffc3f09c9a62932355b8c
sipa commented at 3:15 PM on April 26, 2022: member

utACK bae4561938f66b31420ffc3f09c9a62932355b8c
fanquake merged this on Apr 26, 2022
fanquake closed this on Apr 26, 2022
promag deleted the branch on Apr 26, 2022
sidhujag referenced this in commit 54ea33894e on Apr 26, 2022
DrahtBot locked this on Apr 26, 2023

Contributors

Labels

scripted-diff: rename BytePtr to AsBytePtr #24989

Conflicts