Multiplication result may overflow #24990

issue ImanSharaf opened this issue on April 26, 2022

ImanSharaf commented at 8:54 AM on April 26, 2022: none

I believe there is chance of overflow due to multiplication in this line of code.
ImanSharaf added the label Bug on Apr 26, 2022
MarcoFalke removed the label Bug on Apr 26, 2022
MarcoFalke added the label Questions and Help on Apr 26, 2022
MarcoFalke commented at 10:34 AM on April 26, 2022: member

I haven't looked at this line, but unsigned integer overflow is very common and intentional in src/crypto.
achow101 deleted a comment on Apr 27, 2022
achow101 deleted a comment on Apr 27, 2022
MarcoFalke commented at 6:34 AM on April 27, 2022: member

See also https://github.com/bitcoin/bitcoin/blob/bd616bc16a3a7f70f60ca5034b5a91e5ac89ac9d/src/test/crypto_tests.cpp#L940
MarcoFalke closed this on Apr 27, 2022
DrahtBot locked this on Apr 27, 2023

Contributors

Labels