rework ClientModel::getBlockSource() + BitcoinGUI::setNumBlocks() #2501

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:progress changing 3 files +23 −26

Diapolo commented at 1:55 PM on April 10, 2013: none
- updates ClientModel::getBlockSource() to return all available states and sorts enum BlockSource in order of usage cases (none default, then reindex, import and network)
- updates BitcoinGUI::setNumBlocks() to better use getBlockSource() and also adds a message, when we have NO block source available

rework ClientModel::getBlockSource() + BitcoinGUI::setNumBlocks()

- updates ClientModel::getBlockSource() to return all available states and
  sorts enum BlockSource in order of usage cases (none default, then reindex,
  import and network)
- updates BitcoinGUI::setNumBlocks() to better use getBlockSource() and
  also adds a message, when we have NO block source available

4881353efe

BitcoinPullTester commented at 2:47 PM on April 11, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4881353efef81acc6ddbaaecd4ba89f012b3e87e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 9:02 PM on April 12, 2013: member

ACK. Tested and code changes look fine to me.
Diapolo commented at 2:01 PM on April 13, 2013: none

I would love to see this in 0.8.2 :).
in src/qt/bitcoingui.cpp:None in 4881353efe
```
 534 | +        case BLOCK_SOURCE_REINDEX:
 535 | +            progressBarLabel->setText(tr("Reindexing blocks on disk..."));
 536 | +            break;
 537 | +        case BLOCK_SOURCE_NONE:
 538 | +            // Case: not Importing, not Reindexing and no network connection
 539 | +            progressBarLabel->setText(tr("No block source available..."));
```
laanwj commented at 2:50 PM on April 13, 2013:

Should this message ever appear?

Diapolo commented at 3:09 PM on April 13, 2013:

When you have network problems (internet access, proxy) and before a connection could be made to another node. I find it helpful to have that state shown, as it will tell users there is something not working.

laanwj commented at 3:34 PM on April 13, 2013:

OK, was just wondering
laanwj commented at 3:34 PM on April 13, 2013: member

ACK
Diapolo commented at 12:04 PM on April 18, 2013: none

@laanwj ping :)
laanwj referenced this in commit dc2de757a4 on Apr 18, 2013
laanwj merged this on Apr 18, 2013
laanwj closed this on Apr 18, 2013
laudney referenced this in commit bbf50d6d78 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors