Remove cs_main from verifymessage, move msg utils to new file #25013

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2204-rpc-misc-🔌 changing 5 files +122 −96

MarcoFalke commented at 9:25 AM on April 28, 2022: member
The verifymessage RPC has several issues:
- It takes cs_main for no reason, blocking progress on removing the cs_main global mutex.
- It is located in a file called misc, which is not a very helpful name.
Fix all issues.
Remove cs_main from verifymessage fa9425177e

rpc: Move signmessage RPC util to new file

Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

fa60169811

MarcoFalke added the label Refactoring on Apr 28, 2022
vincenzopalazzo approved
vincenzopalazzo commented at 6:35 PM on April 28, 2022: none

ACK https://github.com/bitcoin/bitcoin/pull/25013/commits/fa60169811d6991a116bd37e1ff58049d2beee77
fanquake merged this on Apr 29, 2022
fanquake closed this on Apr 29, 2022
MarcoFalke deleted the branch on Apr 29, 2022
sidhujag referenced this in commit 8c6f30a47d on Apr 29, 2022
luke-jr referenced this in commit bba1916665 on May 21, 2022
DrahtBot locked this on Apr 29, 2023

Contributors

Labels